chore(atomic): migrate atomic-insight-result-action to Lit#7172
Merged
fbeaudoincoveo merged 15 commits intomainfrom Feb 26, 2026
Merged
chore(atomic): migrate atomic-insight-result-action to Lit#7172fbeaudoincoveo merged 15 commits intomainfrom
fbeaudoincoveo merged 15 commits intomainfrom
Conversation
- Migrate component from Stencil to Lit - Remove @internal annotation to make component public - Add unit tests (12 tests) - Add Storybook stories (7 stories) - Add MDX documentation - Add E2E tests (3 tests) - Fix pre-existing CSS reference issues in atomic-insight-user-actions-timeline and atomic-insight-user-actions-session
…hub.com/coveo/ui-kit into alexprudhomme/insight-result-action-4hh
fbeaudoincoveo
approved these changes
Feb 26, 2026
...s/atomic/src/components/insight/atomic-insight-result-action/atomic-insight-result-action.ts
Show resolved
Hide resolved
alexprudhomme
commented
Feb 26, 2026
...s/atomic/src/components/insight/atomic-insight-result-action/atomic-insight-result-action.ts
Outdated
Show resolved
Hide resolved
…hub.com/coveo/ui-kit into alexprudhomme/insight-result-action-4hh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
atomic-insight-result-actionfrom Stencil to Lit, including new unit tests, E2E tests, Storybook stories, and MDX documentation.Scout camping 🏕️
Small improvements discovered during review, applied for parity or correctness:
setTimeoutused for the "Copied!" tooltip flash. AddeddisconnectedCallbackcleanup and rapid-click debounce (clearTimeoutbefore re-setting).render()andonClick()now bail early when the result context is unavailable, preventing runtime errors.@referencefix inatomic-insight-user-actions-timeline— corrected a wrong Tailwind@referencepath that pointed to a non-existent file.@referenceaddition inatomic-insight-user-actions-session— added the missing Tailwind@referenceimport.Editorial choices 📝
atomic-result-section-actions, hover-reveal inatomic-insight-result-action-bar) with markup examples.@internaltag intentionally removed — the Stencil original had@internal, but removing it is required for the component to appear in the custom elements manifest used by Storybook.static stylesover Tailwindclassprop — the component uses a[part='result-action-button']CSS selector to overriderenderIconButtondefaults (h-8 w-8vs the defaulth-[2.6rem] w-[2.6rem]). This is more reliable than Tailwind class composition, where conflicting utility classes have non-deterministic resolution based on stylesheet generation order.Default(with action dropdown control covering all 5 action types) andInActionBar(showing the hover-reveal placement). Per-action stories were redundant.✅ Checklist
🗑️ Old Cypress tests exclusive to the component are removedN/A: No Cypress tests existed for this component.mdxfile🌐 All strings intended for humans or assistive technology must be localized with i18n.N/A: No user-facing strings; tooltip text is consumer-provided via propsindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-5482