chore(atomic): implement MSW mock of agent api#7174
Draft
erocheleau wants to merge 8 commits intomainfrom
Draft
Conversation
erocheleau
temporarily deployed
to
pr-workflows
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
erocheleau
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
pr-workflows
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Comment on lines
+205
to
+214
| const latencyStream = new TransformStream({ | ||
| start() {}, | ||
| async transform(chunk, controller) { | ||
| const message = messages[messageIndex]; | ||
| const delayMs = message?.delayMs ?? defaultDelay; | ||
| await delay(delayMs); | ||
| messageIndex++; | ||
| controller.enqueue(chunk); | ||
| }, | ||
| }); |
erocheleau
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
reviewed
Feb 27, 2026
Contributor
mmitiche
left a comment
mmitiche
left a comment
There was a problem hiding this comment.
couple comments on the payload of the events, but the setup looks good 👍
Comment on lines
+43
to
+44
| threadId: THREAD_ID, | ||
| runId: RUN_ID, |
Contributor
There was a problem hiding this comment.
These two will not be sent in all the events, they are included only in the RunStarted, RunFinished so I think you can make them optional as well like other properties.
| type: EventType.CUSTOM, | ||
| name: 'header', | ||
| value: { | ||
| conversationId: THREAD_ID, |
Contributor
There was a problem hiding this comment.
As par the latest discussion with KCORE, conversationId will no longer be sent in the header event, because it's already sent in the RunStarted event.
| }), | ||
| // TODO: Citations will be handled separately | ||
| buildMessage({ | ||
| type: EventType.RUN_FINISHED, |
Contributor
There was a problem hiding this comment.
The run finished event also contains a property result, where the KGAS will send us the property answerGenerated: boolean
Comment on lines
+184
to
+185
| : delayBetweenMessages === 'infinite' | ||
| ? Number.POSITIVE_INFINITY |
Contributor
There was a problem hiding this comment.
why do we need the infinity ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFINT-6636
I've added a story and a mock to atomic-generated-answer whenever we're using an agent-id.
WIP