Skip to content

chore: remove more stencil files#7183

Open
louis-bompart wants to merge 17 commits intomainfrom
spring-keep-on-comin
Open

chore: remove more stencil files#7183
louis-bompart wants to merge 17 commits intomainfrom
spring-keep-on-comin

Conversation

@louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Feb 27, 2026

And move item decorators to atomic-legacy

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the ongoing migration of Stencil components to Lit within the packages/atomic codebase. It removes a large set of Stencil-specific utility files (accessibility utils, button components, facet components, interface helpers, etc.), renames initialization-lit-stencil-common-utils.ts to initialization-common-utils.ts to reflect its Stencil-agnostic nature, and moves the resultContext and productContext item decorator functions into packages/atomic-legacy. The packages/atomic public API is kept stable by re-exporting the decorators through @coveo/atomic-legacy/item-decorators.

Changes:

  • Removed a large collection of deprecated Stencil-prefixed utility files from packages/atomic/src (accessibility utils, button/heading/hidden components, facet components, interface helpers, etc.)
  • Renamed initialization-lit-stencil-common-utils.tsinitialization-common-utils.ts and updated all references across the codebase
  • Moved resultContext/productContext item decorators to packages/atomic-legacy with a new build target (tsconfig.decorators.json)

Reviewed changes

Copilot reviewed 45 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-lock.yaml Adds @coveo/headless dependency to packages/atomic-legacy
packages/atomic/src/utils/initialization-common-utils.ts New file (renamed from initialization-lit-stencil-common-utils.ts)
packages/atomic/src/index.ts Re-exports item decorators from @coveo/atomic-legacy/item-decorators; removes stencil-specific decorator exports
packages/atomic/src/utils/initialization-common-utils.spec.ts Import path updated to new filename
packages/atomic/src/utils/init-queue.ts Import updated to new util filename
packages/atomic/src/mixins/bindings-mixin.ts Import updated to new util filename
packages/atomic/src/mixins/bindings-mixin.spec.ts Import and mock path updated
packages/atomic-legacy/src/item-decorators/common.tsx Consolidates decorator utilities; removes ChildTemplatesContext
packages/atomic-legacy/src/item-decorators/index.tsx New re-export barrel for product and result decorators
packages/atomic-legacy/src/item-decorators/product.tsx Updated to import from ./common.js
packages/atomic-legacy/src/item-decorators/result.tsx Updated to import from ./common.js
packages/atomic-legacy/package.json Added @coveo/headless dependency and ./item-decorators export
packages/atomic-legacy/tsconfig.decorators.json New tsconfig for compiling item-decorators with declaration files
packages/atomic/src/components/commerce/atomic-commerce-search-box/e2e/atomic-commerce-search-box.e2e.ts Removes page.reload() since story now sets localStorage via beforeEach
Various fixture/interface files Import paths updated from old to new utils filename
Various deleted Stencil util files Deprecated Stencil-only files removed (no remaining consumers)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment on lines +1 to +2
export * from './product.js'
export * from './result.js' No newline at end of file
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two export lines are missing semicolons, which is inconsistent with the rest of the codebase (e.g., packages/atomic/src/index.ts). Since .tsx files in packages/atomic-legacy are excluded from biome formatting, this won't be caught automatically.

Suggested change
export * from './product.js'
export * from './result.js'
export * from './product.js';
export * from './result.js';

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants