Conversation
…ble types' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
3c15b43 to
11c5d22
Compare
11c5d22 to
506adaa
Compare
There was a problem hiding this comment.
Pull request overview
This PR continues the ongoing migration of Stencil components to Lit within the packages/atomic codebase. It removes a large set of Stencil-specific utility files (accessibility utils, button components, facet components, interface helpers, etc.), renames initialization-lit-stencil-common-utils.ts to initialization-common-utils.ts to reflect its Stencil-agnostic nature, and moves the resultContext and productContext item decorator functions into packages/atomic-legacy. The packages/atomic public API is kept stable by re-exporting the decorators through @coveo/atomic-legacy/item-decorators.
Changes:
- Removed a large collection of deprecated Stencil-prefixed utility files from
packages/atomic/src(accessibility utils, button/heading/hidden components, facet components, interface helpers, etc.) - Renamed
initialization-lit-stencil-common-utils.ts→initialization-common-utils.tsand updated all references across the codebase - Moved
resultContext/productContextitem decorators topackages/atomic-legacywith a new build target (tsconfig.decorators.json)
Reviewed changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Adds @coveo/headless dependency to packages/atomic-legacy |
packages/atomic/src/utils/initialization-common-utils.ts |
New file (renamed from initialization-lit-stencil-common-utils.ts) |
packages/atomic/src/index.ts |
Re-exports item decorators from @coveo/atomic-legacy/item-decorators; removes stencil-specific decorator exports |
packages/atomic/src/utils/initialization-common-utils.spec.ts |
Import path updated to new filename |
packages/atomic/src/utils/init-queue.ts |
Import updated to new util filename |
packages/atomic/src/mixins/bindings-mixin.ts |
Import updated to new util filename |
packages/atomic/src/mixins/bindings-mixin.spec.ts |
Import and mock path updated |
packages/atomic-legacy/src/item-decorators/common.tsx |
Consolidates decorator utilities; removes ChildTemplatesContext |
packages/atomic-legacy/src/item-decorators/index.tsx |
New re-export barrel for product and result decorators |
packages/atomic-legacy/src/item-decorators/product.tsx |
Updated to import from ./common.js |
packages/atomic-legacy/src/item-decorators/result.tsx |
Updated to import from ./common.js |
packages/atomic-legacy/package.json |
Added @coveo/headless dependency and ./item-decorators export |
packages/atomic-legacy/tsconfig.decorators.json |
New tsconfig for compiling item-decorators with declaration files |
packages/atomic/src/components/commerce/atomic-commerce-search-box/e2e/atomic-commerce-search-box.e2e.ts |
Removes page.reload() since story now sets localStorage via beforeEach |
| Various fixture/interface files | Import paths updated from old to new utils filename |
| Various deleted Stencil util files | Deprecated Stencil-only files removed (no remaining consumers) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| export * from './product.js' | ||
| export * from './result.js' No newline at end of file |
There was a problem hiding this comment.
The two export lines are missing semicolons, which is inconsistent with the rest of the codebase (e.g., packages/atomic/src/index.ts). Since .tsx files in packages/atomic-legacy are excluded from biome formatting, this won't be caught automatically.
| export * from './product.js' | |
| export * from './result.js' | |
| export * from './product.js'; | |
| export * from './result.js'; |
And move item decorators to atomic-legacy