v1: Cleanup memory ownership of RAFT_RECEIVE event #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving an AppendEntries RPC it's expected that all entries belong to the same batch. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
If an error occurs ownership of the entries is returned to the caller. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Now the ownership of the entries array is left entirely to the user. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Make a copy of the provided snapshot configuration, and don't discard data upon error. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
freeekanayaka
force-pushed
the
receive-event-memory-ownership
branch
from
0bccd4f to
2ee8f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory ownership of the
RAFT_RECEIVEfields is now consistent with what we do forRAFT_START. See individual commits for details.