Fix freeing of the content model by making use of XML_FreeContentModel#106
Open
hartwork wants to merge 1 commit intocpan-authors:masterfrom
Open
Fix freeing of the content model by making use of XML_FreeContentModel#106hartwork wants to merge 1 commit intocpan-authors:masterfrom
XML_FreeContentModel#106hartwork wants to merge 1 commit intocpan-authors:masterfrom
Conversation
This ensures that any wrapping applied to XML_Memory_Handling_Suite.free_fcn inside of Expat (e.g. adding/ subtracting a constant offset to/from the pointers passed) is not bypassed but respected. Related documentation: - https://libexpat.github.io/doc/api/latest/#XML_SetElementDeclHandler - https://libexpat.github.io/doc/api/latest/#XML_FreeContentModel
Author
|
Any thoughts? |
Member
|
I still need a minute to look, but it looks correct |
Author
|
@toddr cool! Ready to merge? |
Author
|
@toddr ready to merge? |
Author
|
@toddr what does it take to merge? |
2 similar comments
Author
|
@toddr what does it take to merge? |
Author
|
@toddr what does it take to merge? |
Author
@toddr can we move forward with this? |
Author
|
@toddr in two days this pull request will be waiting for review and merging for six months. Can we move forward with this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that any wrapping applied to
XML_Memory_Handling_Suite.free_fcninside of Expat (e.g. adding/subtracting a constant offset to/from the pointers passed) is not bypassed but respected.Related documentation: