Don't gobble up error messages in behavior loader#302
Merged
Conversation
Contributor
|
Let's fix them as needed and in those case consider does it make sense catching the exception in the middle or not. Here since the behavior definitions are part of the user experience, it's good to produce as clear error messages as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into some issues trying to debug failing tests, and found it very annoying that parts of the codebase catch an exception, only to replace it with another exception, discarding the original error message. This was the one I happened to run into, but it seems like the same behaviour occurs in some other places in the codebase as well.
Unsure if I should try to find other spots with the same annoying behaviour to fix in one go or if it's fine to fix them as they appear?