Allow running ProGe tests more in parallel#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been hacking on parts related to RTL generation and running something like
for some 'quick' checks that I haven't accidentally broken any existing functionality. That's pretty slow though, since all the tests only run single-threaded. The fix I went with here is to create a separate test directory for each test and symlink the required data files, so there's no 'real' duplication of shared resources. Does mean that
.oppfiles have to be compiled for each test separately, which is a small downside, but at least in this case there's not that many occurences of them.Likely won't have a significant impact on the CI runtime, but improves my current (and presumably near-future) workflow nicely. Before/after on my machine:
I also extended
systemtest.pyto allow passing multiple root dirs, so the total would then beThis also makes it a bit easier to see what tests leave garbage files lying around, so I added some cleanup handling while I was at it.