Skip to content

Fix workaround on issue 1260 #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 2 commits into from
Jan 8, 2026
Merged

Fix workaround on issue 1260 #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e6291
Remove workaround
mborland Jan 7, 2026
2952aa3
Fix strict aliasing violations
mborland Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions include/boost/decimal/detail/int128/detail/uint128_imp.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,10 @@ constexpr bool operator<(const uint128_t lhs, const uint128_t rhs) noexcept
}
else
{
const uint32_t* l = reinterpret_cast<const uint32_t*>(&lhs);
const uint32_t* r = reinterpret_cast<const uint32_t*>(&rhs);
std::uint32_t l[4] {};
std::uint32_t r[4] {};
std::memcpy(l, &lhs, sizeof(lhs));
std::memcpy(r, &rhs, sizeof(rhs));

if (l[3] != r[3])
{
Expand Down Expand Up @@ -827,8 +829,10 @@ constexpr bool operator<=(const uint128_t lhs, const uint128_t rhs) noexcept
}
else
{
const uint32_t* l = reinterpret_cast<const uint32_t*>(&lhs);
const uint32_t* r = reinterpret_cast<const uint32_t*>(&rhs);
std::uint32_t l[4] {};
std::uint32_t r[4] {};
std::memcpy(l, &lhs, sizeof(lhs));
std::memcpy(r, &rhs, sizeof(rhs));

if (l[3] != r[3])
{
Expand Down Expand Up @@ -980,8 +984,10 @@ constexpr bool operator>(const uint128_t lhs, const uint128_t rhs) noexcept
}
else
{
const uint32_t* l = reinterpret_cast<const uint32_t*>(&lhs);
const uint32_t* r = reinterpret_cast<const uint32_t*>(&rhs);
std::uint32_t l[4] {};
std::uint32_t r[4] {};
std::memcpy(l, &lhs, sizeof(lhs));
std::memcpy(r, &rhs, sizeof(rhs));

if (l[3] != r[3])
{
Expand Down Expand Up @@ -1133,8 +1139,10 @@ constexpr bool operator>=(const uint128_t lhs, const uint128_t rhs) noexcept
}
else
{
const uint32_t* l = reinterpret_cast<const uint32_t*>(&lhs);
const uint32_t* r = reinterpret_cast<const uint32_t*>(&rhs);
std::uint32_t l[4] {};
std::uint32_t r[4] {};
std::memcpy(l, &lhs, sizeof(lhs));
std::memcpy(r, &rhs, sizeof(rhs));

if (l[3] != r[3])
{
Expand Down
5 changes: 0 additions & 5 deletions test/github_issue_1260.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ void test()

int main()
{
// TODO(mborland): GCC 12+ in 32 bit compilations only with release mode fail
#ifndef __i386__

test<boost::decimal::decimal128_t>();
test<boost::decimal::decimal_fast128_t>();

#endif

return boost::report_errors();
}