Don't access current_overlays listener unless it exists.#8
Merged
tomdonaldson merged 2 commits intocpparts:dev_cobaltfrom Sep 26, 2025
Merged
Don't access current_overlays listener unless it exists.#8tomdonaldson merged 2 commits intocpparts:dev_cobaltfrom
tomdonaldson merged 2 commits intocpparts:dev_cobaltfrom
Conversation
cpparts
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is no registered listener for the
current_overlaysevent, then callingremove_overlay()results in aKeyErrorat ipyaladin:widget.py:269 because it tries to access the non-existent listener forcurrent_overlays.The
current_overlaysevent also updatesself._overlaysand that should still happen regardless of whether a listener is registered, so the listener check should happen after that update.A separate issue I noticed is that although
self._overlaysis updated on layer removal (viahandleRemoveOverlay()callinghandleGetOverlays()in message_handler.js),self._overlaysis not updated when a layer is added. Those adds are not as centralized as removals. It's not clear whether it would be best to call the JShandleGetOverlays()on every sort of overlay add or to call the Python version in the relevant add methods.