Open
Conversation
Collaborator
|
What are we going to do about this PR? Can I merge it? |
Collaborator
Author
|
I don't know. You said to me 1y or maybe two ago. That you do not like the solution and you will think about better one. I guess it never happened. The idea here is that security advisor is complaining (quite rightly), that malicious agent can break the logs by adding whitespace to url. This is one way of dealing with it. |
Collaborator
Author
|
Found it. It should be https://pkg.go.dev/net/url#URL.ESCAPEDPATH. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.