Skip to content

Bugfix/request parse#28

Open
PrimeTimeTran wants to merge 4 commits intomasterfrom
bugfix/request-parse
Open

Bugfix/request parse#28
PrimeTimeTran wants to merge 4 commits intomasterfrom
bugfix/request-parse

Conversation

@PrimeTimeTran
Copy link
Collaborator

If we look at the app in production right now we'll see that the api fails.

This is because when the project loads all the source files our petition isn't loaded correctly so throws an error. After fixing that we see the destructuring also throws an error so we fix that while we're here.

Screen Shot 2021-08-16 at 7 15 49 AM

@PrimeTimeTran
Copy link
Collaborator Author

PrimeTimeTran commented Aug 16, 2021

Right now I'm sorta like the "Gate Keeper" of the production api. At some time in the future you'll find yourselves as that person(given you were the one who initially setup the project). The other situation might be you're just a professional and the company gave authority to everything to you. Whatever the case may be, know following this process of PRing features, updating PRs to match criteria as well as "fixing PRs" so it can deploy to production is the skill we're exercising. It should be fun practice. After all if we wanna work at Facebook on React they would do the same thing to update the code base.

@PrimeTimeTran
Copy link
Collaborator Author

PrimeTimeTran commented Aug 16, 2021

Also, long story short, we already configured heroku to use yarn so we need to remove package-lock.json. Depending on who the technical lead is or who configured it the other we might need this file as opposed to yarn.lock. If we're technical lead on the project next time we can go with package-lock.json instead but this time our technical lead also made a decision so we'll just go with that.

If we want want to continue using npm instead of yarn on the cli we can just be careful not to run git add . which would grab that file, package-lock.json. Or, we can use the ui to "remove" that file from staged files for commit after running git add ..

Or we could add this file to .gitignore.

Alas, the challenge with programming sometimes is that there can sometimes be too many ways to solve a problem. haha

remove

The reason it might be good to add to .gitignore is for team members who prefer to use npm on the cli they dont have to constantly run npm install again.

What you guys think? Should we also include package-lock.json to .gitignore? Or should we all agree to use yarn?

@PrimeTimeTran PrimeTimeTran changed the title Bugfix/request parse WIP: Bugfix/request parse Aug 16, 2021
@PrimeTimeTran PrimeTimeTran changed the title WIP: Bugfix/request parse Bugfix/request parse Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant