Skip to content

[LangChain] Fix testing Jupyter Notebook vector_search.ipynb#98

Merged
amotl merged 2 commits intomainfrom
amo/langchain-tests-vector-search
Oct 30, 2023
Merged

[LangChain] Fix testing Jupyter Notebook vector_search.ipynb#98
amotl merged 2 commits intomainfrom
amo/langchain-tests-vector-search

Conversation

@amotl
Copy link
Member

@amotl amotl commented Oct 29, 2023

About

Building upon the test infrastructure added with GH-97, this patch intends to fix a few last flaws within the Jupyter Notebook vector_search.ipynb, primarily to make the software tests succeed.

It also invokes corresponding tests on CI/GHA now.

/cc @ckurze, @WalBeh

@amotl amotl force-pushed the amo/langchain-tests-vector-search branch from 6da6ccf to 50c28d6 Compare October 29, 2023 22:50
@amotl amotl changed the title LangChain: Fix Jupyter Notebook vector_search.ipynb [LangChain] Fix Jupyter Notebook vector_search.ipynb Oct 29, 2023
@amotl amotl force-pushed the amo/langchain-tests-vector-search branch from 50c28d6 to 1e5486a Compare October 29, 2023 22:56
@amotl
Copy link
Member Author

amotl commented Oct 29, 2023

Problem

## inserted before /cells/27/outputs/0:
+  output:
+    output_type: stream
+    name: stderr
+    text:
+      Collection not found

-- https://github.com/crate/cratedb-examples/actions/runs/6686252645/job/18165405211?pr=98#step:5:558

References

@amotl
Copy link
Member Author

amotl commented Oct 30, 2023

Works. 🚀

test.py::test_notebook[document_loader.ipynb]
test.py::test_notebook[vector_search.ipynb]
test.py::test_notebook[conversational_memory.ipynb]

-- https://github.com/crate/cratedb-examples/actions/runs/6686545401/job/18166024142?pr=98#step:5:470

@amotl amotl changed the title [LangChain] Fix Jupyter Notebook vector_search.ipynb [LangChain] Fix testing Jupyter Notebook vector_search.ipynb Oct 30, 2023
@amotl amotl requested review from hlcianfagna, matriv and seut October 30, 2023 00:29
@amotl amotl marked this pull request as ready for review October 30, 2023 00:29
@amotl amotl requested review from ckurze and seut and removed request for hlcianfagna and seut October 30, 2023 11:13
@amotl amotl force-pushed the amo/langchain-tests branch from fb462c9 to b246364 Compare October 30, 2023 15:58
Base automatically changed from amo/langchain-tests to main October 30, 2023 16:00
@amotl amotl force-pushed the amo/langchain-tests-vector-search branch from d679aee to 249d6ee Compare October 30, 2023 16:01
@amotl amotl merged commit 655ef13 into main Oct 30, 2023
@amotl amotl deleted the amo/langchain-tests-vector-search branch October 30, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments