Add import_csv_pandas and import_csv_dask utility primitives#75
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
7a2cb59 to
94b0cdd
Compare
94b0cdd to
f60d9d3
Compare
matriv
approved these changes
Nov 8, 2023
matriv
reviewed
Nov 8, 2023
cratedb_toolkit/util/database.py
Outdated
| pbar = ProgressBar() | ||
| pbar.register() | ||
|
|
||
| # Mangle data. |
There was a problem hiding this comment.
Sorry don't get, what do you mean mangle?
Member
Author
There was a problem hiding this comment.
It's probably a non-word, apologies. I've changed the comment to »Load data into database.« now.
seut
reviewed
Nov 8, 2023
cratedb_toolkit/util/database.py
Outdated
Comment on lines
230
to
231
| # TODO: Use amount of CPU cores instead? | ||
| npartitions = npartitions or 4 |
Member
There was a problem hiding this comment.
Sounds good, lets do it? :)
Or any objections?
Suggested change
| # TODO: Use amount of CPU cores instead? | |
| npartitions = npartitions or 4 | |
| npartitions = npartitions or os.cpu_count() |
ffbb1a0 to
2f7bcd6
Compare
2f7bcd6 to
9259e60
Compare
9259e60 to
e93902b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
More yak shaving.
Details
Similar to pyveci/pueblo#12 and #74, this patch adds generalized testing helper functions to avoid code duplication within the educational repository cratedb-examples, originally conceived at crate/cratedb-examples@dd09e144ef0. We need those kinds of utility functions at many more spots, so we need to find canonical places to store them.
Synopsis
pip install 'cratedb-toolkit[io]'References
Notes
Note that details on the interface may change while we go, specifically on the "naming things" / DWIM side of things. If you have any suggestions, feel free to add your voice. Right now, the main focus is to ship it, to be able to re-use it on behalf of Jupyter Notebooks we are currently publishing, in order to reduce boilerplate code within them.
/cc @karynzv, @marijaselakovic, @hlcianfagna, @hammerhead, @WalBeh, @andnig, @ckurze, @vvulf