SQLAlchemy Dialect: Dependencies: Use sqlalchemy-cratedb>=0.37#94
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
===========================================
+ Coverage 68.44% 80.71% +12.26%
===========================================
Files 68 68
Lines 2732 2712 -20
===========================================
+ Hits 1870 2189 +319
+ Misses 862 523 -339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
force-pushed
the
sqlalchemy-ng
branch
2 times, most recently
from
f095f28 to
610320f
Compare
amotl
changed the title
sqlalchemy-cratedb>=0.37.0
This includes the fix to the `get_table_names()` reflection method.
amotl
changed the title
sqlalchemy-cratedb>=0.37.0sqlalchemy-cratedb>=0.37
surister
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
The new designated CrateDB SQLAlchemy dialect,
sqlalchemy-cratedb, now includes the fix to theget_table_names()reflection method, which has been living as a monkeypatch variant here for a while. @surister supported us to provide test cases to the new upstream package. Thanks.References
get_table_names()reflection method sqlalchemy-cratedb#10sqlalchemy-cratedb>=0.37daq-tools/influxio#128