Fix SQLAlchemy 2.1 compatibility and nightly builds#247
Conversation
…e exists - Add hasattr() check for compile_state._ordered_values before accessing it - SQLAlchemy 2.1.0b1 removed the _ordered_values attribute from DMLState classes - Fixes failing nightly CI tests for object tracking and partial dict updates - Applied fix to both core20.py and core14.py compatibility modules Closes #245
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Update core14.py and core20.py to use double quotes consistently - Resolves ruff formatting violations in compatibility modules
- Fix SQLAlchemy internal API compatibility with enhanced _ordered_values attribute access - Update deprecated datetime APIs (utcfromtimestamp, utcnow) to timezone-aware equivalents - Resolve ObjectNotExecutableError in support polyfill functions - Update test expectations for evolved CrateDB error messages - Add SA_2_1 version constant for future SQLAlchemy compatibility - Maintain backward compatibility across SQLAlchemy 1.3, 1.4, and 2.0+ Resolves 17 test failures in Python 3.14 + latest SQLAlchemy environment while preserving full compatibility with older SQLAlchemy versions.
|
Hi. I was happy about this patch, but I am finding it being closed now. Wasn't it applicable/sensible, i.e. was it wrong? |
|
It has an experiment about asking GitHub Copilot to fix a specific issue, and unfortunately new errors were introduced. I find it safer to close it, and create a new one by hand with some of the changes from this one. |
That will be sweet. Thank you! |
2 participants
About
Fix SQLAlchemy 2.1 compatibility by checking if
_ordered_valuesattribute exists.hasattr()check forcompile_state._ordered_values beforeaccessing it_ordered_valuesattribute from DMLState classescore20.pyandcore14.pycompatibility modulesReview
EXPERIMENT: Do not review or merge this PR.
References