Formatting changes + clarification that most functionality is functions#1
Merged
crawfordsm merged 2 commits intocrawfordsm:ccdprocfrom Feb 5, 2014
Merged
Formatting changes + clarification that most functionality is functions#1crawfordsm merged 2 commits intocrawfordsm:ccdprocfrom
crawfordsm merged 2 commits intocrawfordsm:ccdprocfrom
Conversation
There are still a few undefined variables (transform, distortion, and x/y in the fit example).
crawfordsm
added a commit
that referenced
this pull request
Feb 5, 2014
Formatting changes + clarification that most functionality is functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we are on the same page here, but to confirm:
CCDDataclass,fromFITS, which is denoted in the API doc ascddproc.CCDData.fromFITS.ccdprocpackage rather than being methods of a class;subtract_overscanis an example, and is denoted byccdproc.subtract_overscanI believe this is consistent with the discussion to date at astropy#8