fix loading multple threesixty sliders#52
Open
williscool wants to merge 1 commit intocreativeaura:masterfrom
Open
fix loading multple threesixty sliders#52williscool wants to merge 1 commit intocreativeaura:masterfrom
williscool wants to merge 1 commit intocreativeaura:masterfrom
Conversation
by making sure the progress loader selectors dont collide. just needed to make sure we find the element under the base selector. also corrected the documentation comment on top of the function name
Author
|
also found another fun bug if you control the rotation with window.onscroll and you hit the gotoAndPlay function (by the scroll event triggering) before the slider has loaded all of the images... it will throw a bunch of exceptions in the hidePreviousFrame and showCurrentFrame buttons. I think this has to do with base.getNormalizedCurrentFrame() being calculated with the wrong number of images and thrown off by what gotoAndPlay does to the internal representation of end frame. Fix I did was to just put my window.onscroll function into the onReady call back. And it all just worked. Just thought others might like to know
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by making sure the progress loader selectors dont collide.
just needed to make sure we find the element under the base selector.
also corrected the documentation comment on top of the function name