Fix for jQuery 3.1.1. Issue #87 from creativeaura/threesixty-slider#90
Open
binoalien wants to merge 1 commit intocreativeaura:masterfrom
Open
Fix for jQuery 3.1.1. Issue #87 from creativeaura/threesixty-slider#90binoalien wants to merge 1 commit intocreativeaura:masterfrom
binoalien wants to merge 1 commit intocreativeaura:masterfrom
Conversation
|
Thank you! That bug was doing my head in. I've been trying to move from jQuery 1.11 to 3.x , and it kept failing. I assumed it was an issue with what I copied over, but turns out it was this issue =) |
Igloczek
reviewed
Jul 11, 2018
| "dependencies": {}, | ||
| "devDependencies": { | ||
| "jquery": "~1.8.3" | ||
| "jquery": "~3.1.1" |
Contributor
There was a problem hiding this comment.
I know that author is probably not going to update this package, but you don't need to update required version of jQuery, .on('load', callback) will work on any jQuery, but to avoid some very old version, will be great to define that this package works with >=1.8.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for jQuery 3.1.1. Issue #87 from creativeaura/threesixty-slider