WIP: Add pagination to list controllers#395
Open
olivmai wants to merge 1 commit intocrf-devs:masterfrom
Open
Conversation
mRoca
reviewed
May 11, 2020
mRoca
reviewed
May 11, 2020
mRoca
reviewed
May 11, 2020
mRoca
reviewed
May 17, 2020
olivmai
force-pushed
the
pagination
branch
5 times, most recently
from
551bcc2 to
71c3c80
Compare
fix merge conflicts composer update to fix composer synchro between lock and json fix(ci): remove --configuration for phpstan as it is deprecated fix(ci): undo removing phpstan configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added pagination to :
@mRoca for now I did not use the trait idea we discussed earlier because i had some issues using it in controllers using __invoke methods.
Closes #358