-
Notifications
You must be signed in to change notification settings - Fork 4
Update React to 19 #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React to 19 #287
Changes from all commits
e116d7a
2cd25b3
3fab1c4
a41ea28
a04a861
0eae574
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,8 +17,8 @@ export default function DefaultLayout(props: { | |
| location: Location; | ||
| pageContext: any; | ||
| pageNavigationItems?: PageNavigationItem[]; | ||
| isIduraBannerVisible: boolean; | ||
| onCloseBanner: () => void; | ||
| isIduraBannerVisible?: boolean; | ||
| onCloseBanner?: () => void; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A bit of an unrelated change, I know. But the two required props were causing a TS error in
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nmoskaleva Of course acceptable, just good to document why, in a separate commit :) |
||
| }) { | ||
| const { frontmatter } = props.pageContext; | ||
| const description = frontmatter?.description || frontmatter?.subtitle; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this import to
global.css, otherwise the styles were not applied in the interactive tours.