Fix middleware codemod

[marcospassos]

Summary

This PR fixes a wrong assumption: Next.js doesn't support reexporting middleware matchers. Matchers are now defined using literal strings instead.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[github-actions]

👋 @marcospassos
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

1. You open a new pull request
2. Automated tests check the code
3. Maintainers review the code
4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/croct@106

commit: a0a8970

[Copilot]

Pull Request Overview

This PR updates the Next.js middleware codemod to stop re-exporting matcher configurations and instead inject literal matcher strings, and adjusts the related transformation tests.

• Remove detection of re-exported configs and always inline a config export with a literal matcher pattern.
• Introduce addConfigExport helper to append a config declaration.
• Update existing fixtures by deleting re-export statements and simplify test inputs.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File	Description
test/application/project/code/transformation/fixtures/nextjs-middleware/existingMiddlewareAndConfigReexport.ts	Removed middleware and config re-export fixture content
test/application/project/code/transformation/fixtures/nextjs-middleware/existingLocalConfigAndMiddlewareReexport.ts	Cleared local config and middleware re-export fixture
test/application/project/code/transformation/fixtures/nextjs-middleware/existingConfigReexport.ts	Deleted config re-export fixture
src/application/project/code/transformation/javascript/nextJsMiddlewareCodemod.ts	Dropped config re-export logic, added inline config export helper, and adjusted matcher property handling

Comments suppressed due to low confidence (3)

src/application/project/code/transformation/javascript/nextJsMiddlewareCodemod.ts:129

• [nitpick] This comment indicates only a middleware re-export is added, but the code also appends a config export. Consider updating the comment to reflect both actions for clarity.

                // just add middleware re-export

src/application/project/code/transformation/javascript/nextJsMiddlewareCodemod.ts:54

• Removing the check for re-exported configs may cause the codemod to always inject a new config export even when one is re-exported. Consider reintroducing an isConfigReexported check to skip adding config if it already exists.

        const localConfig = NextJsMiddlewareCodemod.findConfig(input);