chore: Delete unused Dockerfile#327
Open
chlunde wants to merge 1 commit intocrossplane-contrib:masterfrom
Open
chore: Delete unused Dockerfile#327chlunde wants to merge 1 commit intocrossplane-contrib:masterfrom
chlunde wants to merge 1 commit intocrossplane-contrib:masterfrom
Conversation
./cluster/images/provider-sql/Dockerfile is in use, this is not Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
When updating the Dockerfile I noticed this one refers to ancient versions.
I don't see any references to it so lets delete it.
./cluster/images/provider-sql/Dockerfile
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make build e2e still works