feat(mysql): Allow to Grant permissions on specific columns in table#330
Open
ymaniukevich wants to merge 3 commits intocrossplane-contrib:masterfrom
Open
feat(mysql): Allow to Grant permissions on specific columns in table#330ymaniukevich wants to merge 3 commits intocrossplane-contrib:masterfrom
ymaniukevich wants to merge 3 commits intocrossplane-contrib:masterfrom
Conversation
Simplify e2e setup by using the shared code here. This code will support crossplane 2.2.0, which changes the cache paths again. When CROSSPLANE_HELM_CHART_VERSION contains rc we enable --devel for helm to find the appropriate chart. Related: crossplane/build#52 Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
ce36e61 to
b41ee96
Compare
Collaborator
|
@ymaniukevich would it make sense to update the examples to get e2e coverage here? We'll also need to rebase this PR after #328 is in because e2e will fail now |
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
b41ee96 to
21e7234
Compare
Collaborator
|
@ymaniukevich I guess this also fixes #176 ? |
Author
c07dc00 to
6fdc292
Compare
mysql: add e2e tests to cover granting permission on table Signed-off-by: ymaniukevich <yauheni.maniukevich@gmail.com>
6fdc292 to
9c8f974
Compare
Author
@chlunde I've updated the examples to improve e2e coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Improved regexp expression for granting permission to specific columns in MySQL.
Fixes #214, #176
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested