Fix Make targets with registry orgs containing slashes#49
Open
rossigee wants to merge 4 commits intocrossplane:mainfrom
Open
Fix Make targets with registry orgs containing slashes#49rossigee wants to merge 4 commits intocrossplane:mainfrom
rossigee wants to merge 4 commits intocrossplane:mainfrom
Conversation
rossigee
force-pushed
the
fix-registry-targets
branch
from
eba9e37 to
d4afb65
Compare
rossigee
force-pushed
the
fix-registry-targets
branch
from
1729e97 to
e6d7125
Compare
Signed-off-by: Ross Golder <ross@golder.org>
Replace '/' with '-' in registry names for Make target names to avoid invalid targets like img.release.publish.ghcr.io/rossigee.provider-gitea where '/' is treated as a path separator. The IMAGE variable remains unchanged for Docker operations. Signed-off-by: Ross Golder <ross@golder.org>
… format crossplane 2.2 has a new cache key and we need digest format to bypass DNS lookups/API calls. The code works with crossplane 2.1.4 and 2.2.0-rc.1. Related upstream change: crossplane/crossplane#6981 Fixes crossplane/crossplane#7147 Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> Signed-off-by: Ross Golder <ross@golder.org>
rossigee
force-pushed
the
fix-registry-targets
branch
from
ae3eac7 to
a0e46d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace '/' with '-' in registry names for Make target names to avoid invalid targets like img.release.publish.ghcr.io/rossigee.provider-gitea where '/' is treated as a path separator.
The IMAGE variable remains unchanged for Docker operations.