Skip to content

Add version to helm-docs's binary name #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aerfio wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Add version to helm-docs's binary name #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions makelib/helm.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ HELM_INDEX := $(HELM_OUTPUT_DIR)/index.yaml

HELM_DOCS_VERSION ?= v1.14.2
HELM_DOCS_ENABLED ?= false
HELM_DOCS := $(TOOLS_HOST_DIR)/helm-docs
HELM_DOCS := $(TOOLS_HOST_DIR)/helm-docs-$(HELM_DOCS_VERSION)

HELM_VALUES_TEMPLATE_SKIPPED ?= false

Expand Down Expand Up @@ -218,5 +218,7 @@ help-special: helm.help

$(HELM_DOCS):
@$(INFO) installing helm-docs
@GOBIN=$(TOOLS_HOST_DIR) $(GOHOST) install github.com/norwoodj/helm-docs/cmd/helm-docs@$(HELM_DOCS_VERSION) || $(FAIL)
@GOBIN=$(TOOLS_HOST_DIR)/tmp-helm-docs $(GOHOST) install github.com/norwoodj/helm-docs/cmd/helm-docs@$(HELM_DOCS_VERSION) || $(FAIL)
@mv $(TOOLS_HOST_DIR)/tmp-helm-docs/helm-docs $(HELM_DOCS) || $(FAIL)
@rm -fr $(TOOLS_HOST_DIR)/tmp-helm-docs || $(FAIL)
@$(OK) installing helm-docs