Upgrade controller-runtime #905
Draft
+246
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkasztenny
force-pushed
the
upgrade-controller-runtime
branch
from
fd73285 to
2c0fb48
Compare
Turns out this is a bit of a rabbit hole since Go also has to be upgraded, followed by golangci-lint, which causes a lot of deprecation errors to happen. I am not sure how this is typically handled, but I am opening this PR as a draft regardless so others can build on it. Signed-off-by: Adam Kasztenny <adam.kasztenny@elastic.co>
adamkasztenny
force-pushed
the
upgrade-controller-runtime
branch
from
2c0fb48 to
837d3a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The breaking change is described in kubernetes-sigs/controller-runtime#3321.
Turns out this is a bit of a rabbit hole since Go also has to be upgraded, followed by golangci-lint, which causes a lot of deprecation errors to happen.
I am not sure how this is typically handled, but I am opening this PR as a draft regardless so others can build on it.
Fixes #904.
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.