fix: convert listValues to lists in nested structs#102
Merged
bobh66 merged 5 commits intocrossplane:mainfrom Feb 1, 2025
Merged
fix: convert listValues to lists in nested structs#102bobh66 merged 5 commits intocrossplane:mainfrom
bobh66 merged 5 commits intocrossplane:mainfrom
Conversation
fernandezcuesta
force-pushed
the
main
branch
2 times, most recently
from
7474fc8 to
1d2dcb3
Compare
fernandezcuesta
changed the title
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
force-pushed
the
main
branch
from
69b1a97 to
25e49cf
Compare
negz
reviewed
Nov 21, 2024
| k: (struct_to_dict(v) if isinstance(v, structpb.Struct) else v) | ||
| for k, v in s.items() | ||
| } | ||
| return json_format.MessageToDict(s, preserving_proto_field_name=True) |
Member
There was a problem hiding this comment.
Nice. Can you update dict_to_struct as well per #108?
Contributor
Author
There was a problem hiding this comment.
but CI is failing 
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
force-pushed
the
main
branch
from
8724e2d to
c632b0c
Compare
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
force-pushed
the
main
branch
2 times, most recently
from
0250289 to
17d5ddb
Compare
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
force-pushed
the
main
branch
from
17d5ddb to
36e5600
Compare
Collaborator
|
@fernandezcuesta can you please rebase your changes onto the latest main? Thanks! |
bobh66
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
When converting a struct to dict, it is expected for all the fields to be python-bultins. This includes that the resulting nested dict should not contain ListValues but lists.
I have:
Read and followed Crossplane's contribution process.