Merged
Conversation
… detection Reworked DTO hydration and validation to rely fully on Symfony Validator and a centralized `RequestDtoFactory`. - Introduce a new `RequestDtoFactory` to handle recursive DTO instantiation - Detect circular DTO references and throw `CircularReferenceException` - Streamline hydration/validation flow and merge hydration violations correctly - Remove custom `RequestDtoValidator` and `GroupSequenceExtractor` - Integrate `QueryParam` type transformation into the factory - Fix duplicate violation registration caused by name collisions - Improve nested DTO handling and null-safety - Remove `RequestDtoTrait` and update related tests - Update unit and integration tests to reflect the new architecture Refs: `phpstan`, `cs-fixer` BREAKING-CHANGE: Validation and hydration flow has changed; `RequestDtoTrait` was removed
- Adds AbstractParam::hasValueInRequest method. - Refactors RequestDtoValidator to only assign values that have value in request.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…tion edge cases - Add is_array guard in AbstractNestedParam, coerce non-array nested values in - RequestDtoFactory, and support QueryParam transformValue in fromArray path. - Replace individual test methods with parameterized data-provider tests covering - both fromRequest and fromArray, and add comprehensive fixture DTOs for strict, - mixed, non-strict, nested, and circular reference scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue.
Closes #...
What type of PR is this? (check all applicable)
Checklist