Promote main branch to x86_64 assembly.#124
Merged
teodutu merged 21 commits intocs-pub-ro:mainfrom Feb 22, 2026
Merged
Conversation
Linters are now run on the `x86_64` branch as well as `main`. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
- Updated the reading material to mention and demonstrate 8 byte data types. - Added 8 byte traversal requirements to task iterate and updated the solution accordingly Fixes #66 Signed-off-by: Cristi_Sima <cristiansimache@gmail.com>
Ports the source code of lab-04 from x86-32 to x86-64, modifying Makefiles and documentation accordingly Fixes #80 Signed-off-by: Cristian-Stefan Lazar <cristian.lazar1512@gmail.com>
- The reading material was updated to include de 64-bit ISA - The reading material was updated to cover the x86_64 calling convention - The guides materials were updated to 64-bit version - The tasks were updated to 64-bit version and verified to run correctly - The PRINTF32 macro was swapped with the PRINTF64 macro - Added a new task, sum7, in order to prove the x86_64 calling convention - Added a new guide that goes to prove importance of registers saving - Fixed issue where `tasks/rot13/solution/Makefile` was not a symbolic link - Fixed `tasks/to-upper/.gitignore` file - Fixed `tasks/string-print-len/.gitignore` file Signed-off-by: Denis-Marian Vladulescu <denis.vladulescu04@gmail.com>
Update reading materials, guides and tasks to x86_64: * replace PRINTF32 macro with the x86_64 counterpart * update register diagram * update READMEs for tasks, reading materials and guides * update `sum-array` to request only the addition of array elements while migrating squaring the elements to `sum-squared` * add tests to check scenarios with quad word variables Fixes #81 Signed-off-by: Maria Pana <maria.pana4@gmail.com>
Reading material was modified to include x86_64 registers and instructions. Solutions, support code and tests were modified to work on x86_64 assembly and use the extended ISA. Signed-off-by: PetruCristian <naniacristian26@gmail.com>
Adapt tasks and text for lab11 to the x86_64 architecture. Fixes #87 Signed-off-by: Razvan Virtan <virtanrazvan@gmail.com>
Now presents the System V x86-64 ABI. Removed stack-related documentation for now. TBD if we need to treat cases with >6 arguments, floating porint arguments, or arguments whose size exceeds that of a register. Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Practical example with RDTSC. Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Warnings now treated as errors. Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Fixes #85 Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
This commit also changes the navorder of the other tasks & reading. Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
This commit also changes the navorder of the other tasks & reading. Signed-off-by: Radu Mantu <andru.mantu@gmail.com>
Reading material was modified to include x86_64 registers and instructions. Solutions, support code and tests were modified to work on x86_64 assembly and use the extended ISA. Signed-off-by: PetruCristian <naniacristian26@gmail.com>
teodutu
force-pushed
the
x86_64-sync-main
branch
from
eeeaabf to
64987a6
Compare
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the x86_64 branch with main, migrating the codebase from 32-bit (x86) to 64-bit (x86_64) architecture. The changes update assembly code, build configurations, macros, and test infrastructure to support the 64-bit instruction set.
Changes:
- Migration of assembly code from 32-bit to 64-bit registers (e.g.,
eax→rax,ebx→rbx,esp→rsp) - Replacement of
PRINTF32macro withPRINTF64across all files - Updates to build system (Makefiles) to target 64-bit architecture
- Addition of new utility files and tests for 64-bit support
- Infrastructure improvements (Docker, GitHub Actions, VS Code settings)
Reviewed changes
Copilot reviewed 292 out of 437 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| labs/lab-08/tasks//solution/.asm | Convert function implementations to 64-bit calling convention |
| labs/lab-08/tasks//support/.asm | Update skeleton code for 64-bit architecture |
| labs/lab-/utils/printf.asm | Replace 32-bit printf macro with 64-bit version |
| labs/lab-*/support/Makefile | Update build flags for 64-bit compilation |
| labs/lab-02/tasks/iterate/*.c | Add long long iteration support |
| Dockerfile | Upgrade Ruby version and adjust build configuration |
| Makefile | Improve Docker container management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teodutu
changed the title
x86_64 branch with mainmain branch to x86_64 assembly.
The check was usng -eq which triggered a super-linter error. Quite a stupid error if I may add. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
`main` is the new `x86_64` branch and `x86` is the old `main`. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Mostly small typos and bad copy-pastes, but still useful. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
force-pushed
the
x86_64-sync-main
branch
from
ae362a3 to
e19b7c5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 293 out of 432 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Sync
x86_64branch withmain