Modernize typing#22
Conversation
|
@kdeldycke Allowing the workflow unveiled some problems. I fixed one directly on the github web editor, but now more are showing up. Do you want to take a look? I'm happy to continue on my own, but since the PR was originally yours I feel like overstepping. It's mostly references that were lost on the conflict resolution, but the web editor is really not user friendly at all to fix these things. |
|
Hmmm. Ah yes, I guess I produce this PR after #20, hence the mixed up... OK I can fix this one if you prefer. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 97.29% 92.50% -4.80%
==========================================
Files 2 2
Lines 37 40 +3
==========================================
+ Hits 36 37 +1
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
OK I just made the last edits to only introduce minimal changes. All tests are passing. I guess you can squash-merge this PR if it's OK to you. |
|
Thanks for the merge! :) |
This PR use simpler, ad-hoc native types.
It also defers typing in the same spirit as: csala/mdformat-simple-breaks#5