Selenium rewrite #233
Open
Selenium rewrite #233
+22,203
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can ever identify the Edge version reliably, then it will be possible to uncomment this and support Edge 13.x once again. This will be by only having the appropriate flag present for newer versions.
This was a file I had forgotten to save when performing the previous commit.
Adding the doctype declaration means that IE9 renders the testing web page as expected and also fires JavaScript. Further bugs might be found, but this error (where the whole testing website failed to render correctly) is now fixed.
This version of Edge will no longer use the ctrl-click method of toggling selection.
This browser does not work correctly even without the modifier key pressed. It appears that in Edge 14, Microsoft fixed a real bug relating to HTML <select multiple> but they fixed it requiring a modifier key. This commit essentially reverts the work introduced in: 191f7b2 Except that rather than leave that browser commented-out in the build matrix, this commit outright removes it.
This will prevent them from selecting an item by index and will ignore the applicable tests.
I am confident that it was using the right version, so this change is no longer needed.
Undo this change, I can't do it that way. I must use `AddArgument(string)` instead.
This follows lessons learned in the CSF.Extensions.WebDriver project. * Activate xvfb to provide an X environment for the browser * Ensure we're using the right driver version for the env * Upgrade to latest beta of CSF.Extensions.WebDriver
|
The intent here is that I will now benefit from Driver Manager: https://www.selenium.dev/documentation/selenium_manager/ I won't have to manually maintain versions on CI and my dev env.
It seems my previous attempt has not worked
* Avoid splatting a console error in a place that's unwanted * Exit with a failure code if any tests fail * Exclude the non-test web app from tests
….Screenplay into 212-selenium-rewrite
It seems that the issue using the nunit 3 endpoint persists. Look at the history of this file for a now-deleted comment that links to more info about that. It seems that after 6 months, it's still not resolved. The symptom is uploading an nunit 3 test result file which includes test durations expressed in scientific notation causes HTTP 500 errors from the Appveyor endpoint.
….Screenplay into 212-selenium-rewrite
The tests param is unsupported in the .NET scanner.
Also exclude docco from Sonar analysis
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for #212 and related issues. It introduces a complete rewrite of the Selenium library, which has been imported (with history) from CSF.Screenplay.Selenium.