Add cancel mechanisms: double-press and mid-transcription hotkey#12
Merged
Add cancel mechanisms: double-press and mid-transcription hotkey#12
Conversation
Two ways to cancel: - Double-press hotkey (<1.5s recording) discards without transcribing - Press hotkey during transcription to kill the transcription process Also fixes notify_close to use gdbus CloseNotification (the old notify-send -e approach showed an empty notification on GNOME), and runs transcription in background so it can be signal-killed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloseNotificationinstead ofnotify-send -ewhich showed an empty notification on GNOMEtrans.pidTest plan
shellcheck talktypepassesbats test/talktype.bats— all 18 tests pass (15 existing + 3 new)🤖 Generated with Claude Code