Skip to content

Conversation

@stephinson
Copy link
Contributor

This pull request addresses the deprecation of the Buffer() constructor in Node.js by replacing it with Buffer.from(). The Buffer() constructor has been deprecated due to security and usability issues. Using Buffer.from() ensures compatibility with current Node.js versions and adheres to best practices for buffer creation.

Additionally, this update includes:

  • Package upgrades: Updated dependencies to their latest versions to maintain compatibility and security
  • Test enhancements: Updated existing tests to align with the changes

Merging this pull request will eliminate deprecation warnings related to Buffer() usage.

@stephinson
Copy link
Contributor Author

@csquared Let me know if anything’s needed from my side.

@csquared
Copy link
Owner

Thanks for the catch!
Will work on getting this merged and released

@csquared
Copy link
Owner

looks like some issues in the integration tests - I'm sure those have suffered from some bitrot. Any chance you'd want to take a crack at those :D ?

@stephinson
Copy link
Contributor Author

looks like some issues in the integration tests - I'm sure those have suffered from some bitrot. Any chance you'd want to take a crack at those :D ?

Yeah, I'll take a look and patch up the integration tests.

@stephinson
Copy link
Contributor Author

looks like some issues in the integration tests - I'm sure those have suffered from some bitrot. Any chance you'd want to take a crack at those :D ?

Yeah, I'll take a look and patch up the integration tests.

@csquared done.

@csquared
Copy link
Owner

Nice work! Once the integration tests are passing I'm going to merge this and another PR I've been sitting on.

@csquared
Copy link
Owner

@stephinson thank you!

@csquared csquared merged commit 13c6180 into csquared:master Apr 15, 2025
3 checks passed
@csquared
Copy link
Owner

version 0.3.3 released last night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants