-
Notifications
You must be signed in to change notification settings - Fork 11
Add package integration #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IsaacFigNewton
wants to merge
35
commits into
cu-clear:master
Choose a base branch
from
IsaacFigNewton:add_package_integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add package integration #138
IsaacFigNewton
wants to merge
35
commits into
cu-clear:master
from
IsaacFigNewton:add_package_integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added detailed OVERVIEW.md files for BSO, FrameNet, and OntoNotes corpora, describing data structure, usage, and integration. Added TODO.md with a comprehensive refactoring plan to extract business logic into standalone classes (UVI, DataBuilder, Presentation, CorpusMonitor) for improved modularity and maintainability.
Introduces corpora/OVERVIEW.md, providing a comprehensive summary of the UVI corpora collection, its architecture, design principles, data structures, Python API patterns, semantic annotation framework, and integration strategies for cross-resource navigation.
Updated the TODO.md to remove all references to MongoDB and external data dependencies, replacing them with file-based corpus parsing and management. Clarified migration steps, testing strategy, and benefits for a standalone UVI package, and renamed DataBuilder to CorpusLoader throughout. Expanded testing and future considerations for file-based operation and scalability.
Started Phase 1 package implementation Adds the core UVI class with scaffolding for nine linguistic corpora, including VerbNet XML parsing and utility methods. Provides package metadata, example usage, and a comprehensive test suite with mock-based unit tests for initialization, corpus path detection, loading, and VerbNet parsing. Includes pyproject.toml for packaging and development dependencies.
each helper class has specialized functionality
no longer skipping corpus loader tests
added package architecture diagram
added lexical units to the semantic_graph.py example
also fixed pyproject.toml, added plot png download, refactored example semantic_graph.py code, and created unit test file for KG construction
also identified general visualization bugs/issues
for refactoring visualization functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added: