Extended Menu Redesign Pt.1 #318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishanest
approved these changes
Nov 20, 2021
Member
dishanest
left a comment
dishanest
left a comment
There was a problem hiding this comment.
Nice PR! I left a few nits.
| class ExpandedHeaderContainer: UIView { | ||
|
|
||
| private var filterButton: ExpandedFilterButton! | ||
| // private var filterButton: ExpandedFilterButton! |
| categoryLabel.text = category | ||
| categoryLabel.font = .systemFont(ofSize: 18, weight: .semibold) | ||
|
|
||
| super.init(frame: .zero) |
danielVebman
approved these changes
Nov 20, 2021
Npikielny
approved these changes
Nov 22, 2021
Comment on lines
+57
to
+59
| make.leading.equalToSuperview() | ||
| make.trailing.equalToSuperview() | ||
| make.bottom.equalToSuperview() |
Contributor
There was a problem hiding this comment.
Can be shortened: make.leading.trailing.bottom.equalToSuperview()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the first of many PRs to come that are leading up to the Eatery redesign. This PR focuses on the fixes to Extended Menu
Changes Made
Test Coverage
Tested on iPhone 13, iPhone 12 and actual device (XR)
Next Steps (delete if not applicable)
Screenshots (delete if not applicable)
Screen Recording
RPReplay_Final1637364995.MP4