feat: editor tokens for the names of Feature, Rule, Scenario keywords#249
feat: editor tokens for the names of Feature, Rule, Scenario keywords#249ant0x64 wants to merge 3 commits intocucumber:mainfrom
Conversation
|
@michaelboyles can you review this? |
|
Seems like a hack really. 'Scenario' is not semantically a function and 'Rule' is not semantically a class. You could make the argument that Feature is a namespace of sorts, I guess. You're basically assigning any otherwise-unused token type, just so it's unique from the others. The root issue that is monaco doesn't let you style distinct keywords with different styles. I think there are 3 problems with this PR
|
|
@luke-hill, my mistake, fixed tests. |
|
I agree that mapping I also considered leaving
As someone new to this package, I’d appreciate guidance on how this mapping is typically surfaced. Personally, I’ve been using VSCode’s built-in Editor Token Inspection Tool to identify token types for styling. Is there a more maintainable or standard approach to documenting or discovering these token mappings? I understand the concern about future token use conflicts and theming side effects. I’m very open to alternative suggestions or a better strategy if there’s a preferred path forward |
|
I'm afraid that at present we collectively lack the expertise to make such a decision - one way or another. |
Fixes #248
This feature introduces new token classifications for the names of Feature, Rule and Scenario blocks in Cucumber feature files:
🏷️ What kind of change is this?