fix: comprehensive pm-dev-java plugin-doctor cleanup#7
Merged
cuioss-oliver merged 3 commits intomainfrom Feb 23, 2026
Merged
Conversation
- Rename java-create to java-core (fixes identity mismatch) - Rename java-optimize-quarkus-native to java-quarkus (fixes title/name mismatch) - Add missing CONTINUOUS IMPROVEMENT RULE to all 9 agents - Standardize CI RULE to modern manage-lessons pattern - Remove unused Write/Edit tools from read-only agents - Replace non-existent pm-dev-builder:builder-maven-rules with pm-dev-java:plan-marshall-plugin (31 replacements across 11 files) - Fix broken cross-references (java-cdi-quarkus → java-quarkus, java-core paths) - Rename CRITICAL RULES to Enforcement block in java-enforce-logrecords - Remove banned ALL-CAPS keywords outside enforcement blocks - Add unreferenced pom-maintenance.md to plan-marshall-plugin references - Replace vague workflow delegation with explicit script call in java-refactor-agent - Document unreferenced profiles.py script in manage-maven-profiles - Fix component type metadata (command → skill) in CI RULE sections - Update all tests and cross-bundle references Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @cuioss-oliver, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive cleanup and standardization of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request provides a comprehensive cleanup and standardization of the pm-dev-java bundle. Renaming skills to more descriptive names (e.g., java-create to java-core) and standardizing the CONTINUOUS IMPROVEMENT RULE across agents improves consistency. The migration from the external pm-dev-builder dependency to the internal plan-marshall-plugin is a significant architectural improvement. However, there are several critical issues where the new skill is invoked using non-existent workflows (Execute Maven Build), which will cause runtime failures for the agents. Additionally, some sections violate Rule 9 by using descriptive text instead of actionable bash blocks for script operations. There are also some remaining all-caps keywords that should be addressed to align with the PR's stated goals.
marketplace/bundles/pm-dev-java/skills/java-full-workflow/SKILL.md
Outdated
Show resolved
Hide resolved
marketplace/bundles/pm-dev-java/skills/java-enforce-logrecords/SKILL.md
Outdated
Show resolved
Hide resolved
marketplace/bundles/pm-dev-java/skills/java-maintain-logger/SKILL.md
Outdated
Show resolved
Hide resolved
marketplace/bundles/pm-dev-java/skills/java-maintenance/SKILL.md
Outdated
Show resolved
Hide resolved
...ndles/pm-plugin-development/skills/plugin-architecture/references/minimal-wrapper-pattern.md
Outdated
Show resolved
Hide resolved
…cit script calls - Replace all `Skill:/Workflow: Execute Maven Build` blocks with explicit `python3 .plan/execute-script.py pm-dev-java:plan-marshall-plugin:maven run` calls in java-full-workflow, java-enforce-logrecords, java-maintain-logger - Convert descriptive Skill references to bash blocks in java-maintenance (Rule 9) - Fix `**CRITICAL:**` to `**Critical:**` in CI RULE sections of java-quality-agent, java-refactor-agent, java-verify-agent - Replace non-existent workflow refs in minimal-wrapper-pattern.md with explicit script notation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java-create→java-core,java-optimize-quarkus-native→java-quarkus(fixes identity/title mismatches)manage-lessonspattern, removed unused Write/Edit tools from read-only agentspm-dev-builder:builder-maven-ruleswithpm-dev-java:plan-marshall-plugin, fixed brokenjava-cdi-quarkus→java-quarkusrefsCRITICAL RULES→Enforcementinjava-enforce-logrecords, removed banned ALL-CAPS keywords outside enforcement blocksTest plan
./pw verify pm-dev-java— 100 tests pass./pw module-tests plan-marshall— 744 tests pass🤖 Generated with Claude Code