Draft
Conversation
keyboard-slayer
force-pushed
the
kbd-port
branch
5 times, most recently
from
9f5881a to
6f6a04b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a port system for managing external dependencies that need custom build procedures. The system allows fetching sources from Git repositories, applying patches, and executing custom build scripts to produce library or executable artifacts.
- Adds
Portcomponent type with support for fetching, preparing, building, and packaging external dependencies - Integrates ports into the build system with a new
ck-portrule and tool - Implements port discovery and loading from a dedicated
ports/directory with Python-based build scripts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| cutekit/const.py | Adds PORTS_DIR constant for the ports directory location |
| cutekit/model.py | Implements Port and PortScope classes, port loading logic, and integration with the install command |
| cutekit/rules.py | Adds ck-port build rule for executing port build scripts |
| cutekit/builder.py | Integrates ports into the build system with port execution tool and library/executable handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cutekit/model.py
Outdated
Comment on lines
813
to
818
| class PortScope: | ||
| srcDir: Path | ||
| destDir: Path | ||
| destFile: Path | ||
| cwd: Path | ||
|
|
There was a problem hiding this comment.
The PortScope class lacks documentation. As a new public data structure used in the port system API, it should have a docstring explaining its purpose and the meaning of each field.
Member
Author
|
TL;DR of copilot: I should make some docstrings |
keyboard-slayer
force-pushed
the
kbd-port
branch
2 times, most recently
from
257bccf to
a6f4c6d
Compare
keyboard-slayer
force-pushed
the
kbd-port
branch
15 times, most recently
from
b507aae to
f181130
Compare
sleepy-monax
force-pushed
the
kbd-port
branch
from
f181130 to
cba95dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.