Batch Scanning, added an option to output the images content of NAPS2 from this panel.#696
Batch Scanning, added an option to output the images content of NAPS2 from this panel.#696christianclavet wants to merge 2 commits intocyanfish:masterfrom
Conversation
…tch output. Also. Disable the LOAD option when the option is selected.
| @@ -1,5 +1,110 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Please don't include the changes to localized files, these will be updated as part of the release process
| private readonly Button _start = new() { Text = UiStrings.Start }; | ||
| private readonly Button _cancel = new() { Text = UiStrings.Cancel }; | ||
| private readonly DropDownWidget<ScanProfile> _profile = new(); | ||
| private readonly RadioButton _UseExistingImages; |
There was a problem hiding this comment.
This should start with a lowercase letter to match, but also let's rename this to _loadFromNaps2 (and, optionally, you can also rename _load to _loadIntoNaps2)
| <EmbeddedResource Remove="ClientCreds_.resx" /> | ||
| <Compile Remove="ClientCreds_.Designer.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
These changes also shouldn't be included
|
|
||
| public enum BatchScanType | ||
| { | ||
| UseExistingImages, |
| using Eto.Forms; | ||
| using Eto.Forms; | ||
| using NAPS2.EtoForms; | ||
| using NAPS2.EtoForms.Desktop; |
There was a problem hiding this comment.
The only change to usings here should be adding using NAPS2.Images;
There was a problem hiding this comment.
If I touch theses, lots of errors pop out, I cannot remove them. using NAPS2.Images is there but it's greyed as if it was not used.
| <data name="StopScannerSharing" xml:space="preserve"> | ||
| <value>Stop Scanner Sharing</value> | ||
| </data> | ||
| <data name="UseExistingImages" xml:space="preserve"> |
There was a problem hiding this comment.
Let's call this LoadFromNaps2 with a string "Load images from NAPS2" (to be consistent with the output string of "Load images into NAPS2")
| ShowUpdatePrompt(); | ||
| } | ||
|
|
||
| public UiImageList GetImages() |
There was a problem hiding this comment.
This shouldn't be necessary any more
There was a problem hiding this comment.
Ok, removed. There doesnt seem to have any reference to it.
| L.GroupBox( | ||
| UiStrings.ScanConfig, | ||
| L.Column( | ||
| _UseExistingImages, |
There was a problem hiding this comment.
Let's move this to the bottom of the column (below the ).Padding(left: 20).Visible(_delayVis) line)
2 participants
Hi, This is a new option to the Batch Scanning panel.
It provide a way to use the already scanned images and use the output functions. Right now, it can become useful, if you scanned images with PATCH "T" symbol. So it enable the use to scan multiple documents, do some work over them and export them as multiple documents with the Patch "T" images.
When the option is checked it will disable the LOAD option when the option is selected since It would loop the data between what is in NAPS and what is put in NAPS2. The LOAD option will become enabled again, if the user selection another option.
Later On, I plan to add more features to this panel. Output a text containing a filelist, that could be used a signal to allow other software to get the image and use NAPS2 as the document scanner part of the document solution.
NOTE: The changes affect only the Windows build for the moment, the GUI work for MAC and Linux need to be done.
Thanks
Christian Clavet
Montreal