Fix documentation and tag verification#2
Open
gkuenning wants to merge 3 commits intocytopia:masterfrom
Open
Conversation
Don't assume that tags are always followed by commas. Also handle tags that are commits rather than object; git verify-tag rejects commit tags.
For consistency, output to the log file using printf rather than echo. Also correct the usage of printf to be robust against the possibility that PROGRAM_EXIT_TEXT might contain a percent sign.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that "git verify-tag" breaks on tags that are to commits. This PR corrects that, plus does a bit of documentation and code cleanup.