Return as soon as we have a port for the current hostname#18
Open
RealOrangeOne wants to merge 5 commits intomasterfrom
Open
Return as soon as we have a port for the current hostname#18RealOrangeOne wants to merge 5 commits intomasterfrom
RealOrangeOne wants to merge 5 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than once all are enumerated. Enumerating processes is pretty fast anyway, but the faster we can make it the better!
(Has a bit of an impact on #17, as this blocks all requests until it's finished)
This should be tested on macOS, as it might do strange things there (hence the base
except). Works fine for me!I've also added support for specifying multiple hostnames, a niche but potentially really useful change.