avoid sed for netlify-build due to osx support#24
Open
josephwegner wants to merge 1 commit intodaily-demos:mainfrom
Open
avoid sed for netlify-build due to osx support#24josephwegner wants to merge 1 commit intodaily-demos:mainfrom
josephwegner wants to merge 1 commit intodaily-demos:mainfrom
Conversation
|
👷 Deploy request for call-object-react accepted. 🔨 Explore the source changes: 087738c 🔍 Inspect the deploy log: https://app.netlify.com/sites/call-object-react/deploys/60ef3209a08ff500079f4ddd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sedis a little bit finicky depending on your platform and shell. On OS X withzsh, thenetlify-buildcommand fails because it is usingsedto insert theDAILY_API_KEYintonetlify.toml. The error would be:It's not as clean
sed, but this PR used perl to do the replacement instead.This PR also installs
dotenv-cliso that we can pull variables directly out of.env. Right now I believe it just expectsDAILY_API_KEYto be exported in the shell.