-
Notifications
You must be signed in to change notification settings - Fork 107
Support python 3.13/cython 3 #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for this! (I can't quite work out how to permanently enable running tests for this PR so I have to keep manually enabling...) |
|
No worries! |
|
currently replicating CI locally as I was not getting import errors (or i wouldn't have submitted the pr) |
|
Well, that's bizarre. Runs fine when invoking |
|
@daler made a few adjustments if you would give it an approval :) |
|
seems genomepy doesn't actually support 3.13 yet-dunno if that's a blocker |
|
easy fix tbh simonvh/norns#10 |
|
so it turns out that the directory was a red herring for cython having trouble locating the naked cpdef in cbedtools-so i just added it to init.py and called it a day. should(?) work now |
|
oh for God's sake I literally excluded that file |
|
once more |
|
Fantastic! Thanks for working out all the details. I don't have the bandwidth that I used to, so this is super helpful. At some point I'll need to do a more careful review of those .pxd files (i.e., prob don't need language level 2 any more) but at least this builds on 3.13. Will cut a release shortly. |
|
Uh oh...upon uploading to TestPyPI, I'm unable to install locally on macOS or Linux with the following: conda create -y -p ./env "python>=3.13"
conda activate ./env
python3 -m pip install \
--index-url https://test.pypi.org/simple/ \
--extra-index-url https://pypi.org/simple/ pybedtools==0.12I haven't quite figured out why it passed here though. |
|
pulling it down from test.pypi on my end shows cpp files generated by 0.29, which would do that. Just delete the cpp files from the sdist, modern setuptools is smart enough to handle it. |
|
Ugh, looks like I hadn't run the |
Apparently it Just Works with Cython 3 if you move the distutils stuff over to setuptools. Who'dve thought. (can't verify all tests right now but passed most of them and then ran out of space).
reference issue #422