Skip to content

Comments

Remove ValueError if hostname does not contain dot#577

Open
pirlgon wants to merge 1 commit intodalibo:v7from
pirlgon:handle_hostname
Open

Remove ValueError if hostname does not contain dot#577
pirlgon wants to merge 1 commit intodalibo:v7from
pirlgon:handle_hostname

Conversation

@pirlgon
Copy link

@pirlgon pirlgon commented Jul 8, 2022

ValueError has been replaced with Warning message if dot
is missing.

ValueError has been replaced with Warning message if dot
is missing.
@codecov-commenter
Copy link

Codecov Report

Merging #577 (3b5c0ff) into v7 (11f83d4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##               v7     #577   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files          43       43           
  Lines        3359     3359           
=======================================
  Hits          512      512           
  Misses       2847     2847           
Impacted Files Coverage Δ
temboardagent/inventory.py 17.24% <0.00%> (-0.15%) ⬇️
temboardagent/tools.py 31.74% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f83d4...3b5c0ff. Read the comment docs.

@bersace
Copy link
Member

bersace commented Jul 8, 2022

Peux-tu ajouter une entrée dans CHANGELOG.md ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants