docs: migrate agent-runtime docs to centralized documentation#84
Merged
yacosta738 merged 8 commits intomainfrom Feb 25, 2026
Merged
docs: migrate agent-runtime docs to centralized documentation#84yacosta738 merged 8 commits intomainfrom
yacosta738 merged 8 commits intomainfrom
Conversation
- Move docs from clients/agent-runtime/docs to docs site structure
- Add architecture documentation (en/es) with system overview
- Add CI workflow map documentation (en/es)
- Add PR workflow documentation (en/es)
- Update CONTRIBUTING.md to link to new doc URLs in repo
- Delete old docs directory after confirming no references
Docs now live in: docs/src/content/docs/{lang}/clients/agent-runtime/
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
corvus-plugins-edge | 1eb19b5 | Feb 25 2026, 04:56 PM |
Contributor
📝 WalkthroughWalkthroughUpdates add English and Spanish agent-runtime documentation, adjust documentation links and image paths, rename several Kotlin composable functions to camelCase, change some Compose state persistence and send-button logic, update onboarding string resources and add Spanish locale file, and remove a few external AIEOS hyperlinks. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying corvus-plugins with
|
| Latest commit: |
1eb19b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b9b3232d.corvus-plugins.pages.dev |
| Branch Preview URL: | https://agent-docs.corvus-plugins.pages.dev |
✅ Contributor ReportUser: @yacosta738
Contributor Report evaluates based on public GitHub activity. Analysis period: 2025-02-25 to 2026-02-25 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.kt (1)
98-99:⚠️ Potential issue | 🟠 MajorDo not persist auth secrets with
rememberSaveable.Lines 98-99 persist
bearerTokenandwebhookSecretvia saved instance state, which survives process death and app restart. These values should userememberinstead to keep them in-memory only, reducing credential exposure risk.Note: Line 97's
pairingCodeis also a credential (used as theX-Pairing-Codeheader) and should be updated torememberfor consistency.Proposed fix
- var pairingCode by rememberSaveable { mutableStateOf("") } - var bearerToken by rememberSaveable { mutableStateOf("") } - var webhookSecret by rememberSaveable { mutableStateOf("") } + var pairingCode by remember { mutableStateOf("") } + var bearerToken by remember { mutableStateOf("") } + var webhookSecret by remember { mutableStateOf("") }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.kt` around lines 98 - 99, The code currently persists credentials by using rememberSaveable for bearerToken and webhookSecret (and pairingCode at line 97) which stores them in saved instance state; change their declarations to use remember instead of rememberSaveable so these values remain in-memory only (replace mutableStateOf usages for bearerToken, webhookSecret, and pairingCode to use remember { mutableStateOf("") }), ensuring the state variables remain transient and do not survive process death or restart.
🧹 Nitpick comments (2)
.agents/journal/bolt-journal.md (1)
47-47: Add benchmark context for reproducibility.At Line 47 and Line 73, please include the benchmark environment and command details (machine/CI runner, clean vs incremental, Gradle tasks, run count). Right now the numbers are useful but hard to reproduce or compare over time.
Also applies to: 73-73
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/journal/bolt-journal.md at line 47, The benchmark note "Incremental baseline: ~10.7s → Incremental post-optimization: ~1.4s. Verified functional correctness with `:composeApp:check`." should include reproducibility details: append the machine/CI runner (OS, CPU, RAM), whether the run was clean or incremental, exact Gradle command used (including flags and wrapper/version), number of runs and how the times were aggregated (median/mean), and any relevant environment vars; make the same addition for the analogous entry at the other occurrence (the line referenced at 73) so both entries contain identical benchmark context for reproducibility.clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ConfigPanel.kt (1)
57-90: Externalize UI strings for localization consistency.Line 57 through Line 90 currently mixes hardcoded Spanish and English labels/placeholders. Moving these into shared string resources will keep the config panel consistent across locales and easier to maintain.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ConfigPanel.kt` around lines 57 - 90, The UI strings in ConfigPanel (labels/placeholders for the OutlinedTextField and PasswordTextField usages) are hardcoded; extract all user-facing text (e.g., "URL base del agente", ChatWorkspaceDefaults.DefaultGatewayBaseUrl placeholder, "Pairing code (X-Pairing-Code)", "Codigo de 6 digitos", "Bearer token", "zc_...", "Webhook secret (opcional)", "X-Webhook-Secret") into shared/localized string resources and replace the inline literals in ConfigPanel.kt with references (e.g., Strings.resourceName) so both OutlinedTextField and PasswordTextField call localized values; update any callers or previews to use the resource provider as needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/agent-runtime/CONTRIBUTING.md`:
- Around line 50-51: The two markdown links currently pointing to
`clients/web/apps/docs/src/content/docs/en/clients/agent-runtime/pr-workflow.md`
and `clients/web/apps/docs/src/content/docs/en/clients/agent-runtime/ci-map.md`
are resolved relative to `clients/agent-runtime/` and thus broken; update them
to use the correct relative path from `clients/agent-runtime/` (e.g., prefix
with the proper parent traversal so they point to
`../web/apps/docs/src/content/docs/en/clients/agent-runtime/pr-workflow.md` and
`../web/apps/docs/src/content/docs/en/clients/agent-runtime/ci-map.md`) so
repository docs navigation and link checks succeed.
In
`@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.kt`:
- Around line 89-90: The contentDescription currently hardcodes "Hide"/"Show" in
ChatComponents.kt; replace those literals with localized strings via
stringResource (e.g., stringResource(R.string.show_password) and
stringResource(R.string.hide_password)) and reference them where
contentDescription is set (the branch using isVisible). Add the two string
resources (show_password, hide_password) to your Android/i18n resource files
(and translations), then use stringResource(...) in the composable so
screen-reader text matches the UI language.
- Line 67: The CI fails because composable functions in ChatComponents.kt use
PascalCase (e.g., PasswordTextField and the other composable around line 97),
violating Detekt FunctionNaming; rename these functions to lowerCamelCase (e.g.,
passwordTextField and the corresponding lowerCamel name for the second
composable), keep the same signature, visibility (internal), and `@Composable`
annotation, update all call sites/usages in the codebase to the new names, run
formatter/detekt to ensure no remaining naming violations.
In
`@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.kt`:
- Around line 294-295: The send button is enabled for whitespace-only input
because isSendEnabled uses query.isNotBlank(); update ChatWorkspace.kt to
compute trimmed input and use that for the button enablement (e.g., set
isSendEnabled = query.trim().isNotBlank()), ensuring the enabled state matches
the validation performed in sendMessage(); keep using actions.onSend as the
click handler but base enablement on the trimmed query variable.
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md`:
- Around line 5-7: Corrige los errores ortográficos y anglicismos en la
introducción: cambia "autonomousos" por "autónomos", reemplaza "garbage
collection" por "recolector de basura" o «recolección de basura», y limpia la
repetición de "alto" agrupando las cualidades en una sola lista ("alto
rendimiento, eficiencia, estabilidad, extensibilidad, sostenibilidad y
seguridad") además de ajustar la redacción de la segunda oración para fluidez
manteniendo las referencias a Rust como lenguaje sin recolector de basura y con
seguridad de tipos en tiempo de compilación; busca las frases exactas "El Agent
Runtime de Corvus", "autonomousos" y "garbage collection" para aplicar los
cambios.
- Around line 89-105: Corrige los errores de redacción y mezcla de idiomas en el
bloque: reemplaza "rompel" por "romper", "restrict" por "restringen" (o
"restringen el alcance"), y "alternating" por "alternando"; además normaliza
cualquier término en inglés al español y asegúrate de concordancia gramatical en
las frases que mencionan los módulos `security/`, `providers/reliable.rs` y
`agent/` para mantener todo el texto en español consistente con las directrices
de estilo del proyecto.
- Around line 121-173: Resumen: unificar la terminología al español y corregir
errores tipográficos en el texto (p. ej. "persisitdo", "declarative",
"foundation", "autonomousos") para mantener consistencia. Instrucciones:
reemplaza "persisitdo" por "persistido", "declarative" por "declarativo",
"foundation" por "base" y "autonomousos" por "autónomos"; revisa y normaliza
términos técnicos manteniendo identificadores de código en inglés cuando sean
nombres de carpetas o traits (ej.: `providers/`, `channels/`, trait Provider,
trait Channel, trait Tool) y convierte palabras mezcladas o repetidas ("Discord
Discord.js") a la forma correcta; además aplica tildes y ortografía correcta en
todo el bloque (por ejemplo "SQLite persisitdo" → "SQLite persistido", "lenguaje
de declarative" → "lenguaje declarativo") y vuelve a leer todo el archivo para
asegurar coherencia terminológica en las secciones
Memory/Tools/Peripherals/Security/Infrastructure/Extensibility/Performance/Security
Model/Conclusion.
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md`:
- Around line 25-30: Translate the English branch-protection bullet list to
Spanish so it matches the rest of the document: replace the items "Require
status checks before merge", "Require check `CI Required Gate`", "Require pull
request reviews before merge", "Require CODEOWNERS review for protected paths",
"Dismiss stale approvals when new commits are pushed", and "Restrict force-push
on protected branches" with concise Spanish equivalents, keeping inline
code/backticks for `CI Required Gate` and CODEOWNERS and preserving the bullet
formatting in pr-workflow.md.
---
Outside diff comments:
In
`@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.kt`:
- Around line 98-99: The code currently persists credentials by using
rememberSaveable for bearerToken and webhookSecret (and pairingCode at line 97)
which stores them in saved instance state; change their declarations to use
remember instead of rememberSaveable so these values remain in-memory only
(replace mutableStateOf usages for bearerToken, webhookSecret, and pairingCode
to use remember { mutableStateOf("") }), ensuring the state variables remain
transient and do not survive process death or restart.
---
Nitpick comments:
In @.agents/journal/bolt-journal.md:
- Line 47: The benchmark note "Incremental baseline: ~10.7s → Incremental
post-optimization: ~1.4s. Verified functional correctness with
`:composeApp:check`." should include reproducibility details: append the
machine/CI runner (OS, CPU, RAM), whether the run was clean or incremental,
exact Gradle command used (including flags and wrapper/version), number of runs
and how the times were aggregated (median/mean), and any relevant environment
vars; make the same addition for the analogous entry at the other occurrence
(the line referenced at 73) so both entries contain identical benchmark context
for reproducibility.
In
`@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ConfigPanel.kt`:
- Around line 57-90: The UI strings in ConfigPanel (labels/placeholders for the
OutlinedTextField and PasswordTextField usages) are hardcoded; extract all
user-facing text (e.g., "URL base del agente",
ChatWorkspaceDefaults.DefaultGatewayBaseUrl placeholder, "Pairing code
(X-Pairing-Code)", "Codigo de 6 digitos", "Bearer token", "zc_...", "Webhook
secret (opcional)", "X-Webhook-Secret") into shared/localized string resources
and replace the inline literals in ConfigPanel.kt with references (e.g.,
Strings.resourceName) so both OutlinedTextField and PasswordTextField call
localized values; update any callers or previews to use the resource provider as
needed.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (3)
assets/architecture.svgis excluded by!**/*.svgclients/agent-runtime/Cargo.lockis excluded by!**/*.lock,!**/Cargo.lockclients/agent-runtime/docs/architecture.svgis excluded by!**/*.svg
📒 Files selected for processing (17)
.agents/command/scribe.agent.md.agents/journal/bolt-journal.mdassets/corvus-architecture-2025-12-26-1951.excalidrawclients/agent-runtime/CONTRIBUTING.mdclients/agent-runtime/README.mdclients/composeApp/build.gradle.ktsclients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.ktclients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.ktclients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ConfigPanel.ktclients/web/apps/docs/src/content/docs/en/clients/agent-runtime/architecture.mdclients/web/apps/docs/src/content/docs/en/clients/agent-runtime/ci-map.mdclients/web/apps/docs/src/content/docs/en/clients/agent-runtime/index.mdxclients/web/apps/docs/src/content/docs/en/clients/agent-runtime/pr-workflow.mdclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.mdclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/ci-map.mdclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/index.mdxclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
💤 Files with no reviewable changes (1)
- .agents/command/scribe.agent.md
clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.kt
Outdated
Show resolved
Hide resolved
clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.kt
Show resolved
Hide resolved
clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.kt
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
Deploying corvus with
|
| Latest commit: |
1eb19b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2b07019.corvus-42x.pages.dev |
| Branch Preview URL: | https://agent-docs.corvus-42x.pages.dev |
CONTRIBUTING.md: - Fix relative paths to doc files (add ../ prefix) aieos.org links (site no longer exists): - README.md (root): remove link to aieos.org - clients/agent-runtime/README.md: remove links to aieos.org - clients/agent-runtime/src/identity.rs: remove reference to aieos.org ES documentation: - architecture.md: fix spelling errors (autonomousos→autónomos, garbage collection→recolector de basura, rompel→romper, restrict→restringen, alternating→alterna, persisitdo→persistido, declarative→declarativo, foundation→base) - pr-workflow.md: translate English bullet list to Spanish composeApp: - ChatComponents.kt: rename composables to camelCase (passwordTextField, endpointsSection, endpointCard) to satisfy Detekt FunctionNaming - ChatWorkspace.kt: use trimmed query for send button enablement; use remember instead of rememberSaveable for credentials (pairingCode, bearerToken, webhookSecret) to keep them in-memory only - ConfigPanel.kt: update call sites to use renamed composables - strings.xml: add show_password/hide_password string resources (values-en for English translations) Note: stringResource usage was reverted due to internal visibility limitation in generated resources - strings remain hardcoded for now.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
clients/composeApp/src/commonMain/composeResources/values/strings.xml (1)
1-19:⚠️ Potential issue | 🟡 Minor
values/is the fallback for all unmatched locales — currently Spanish.In Compose Multiplatform,
values/is the catch-all fallback. With Spanish as the only content there, any device locale that isn't explicitlyen(e.g., French, German, Japanese) silently receives Spanish strings — unexpected UX.Consider either:
- Swapping conventions — move English strings to
values/as the universal fallback and Spanish tovalues-es/, or- Ensuring this is a deliberate product decision (Spanish-first app) and documenting it.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/composeApp/src/commonMain/composeResources/values/strings.xml` around lines 1 - 19, The values/ directory currently contains Spanish strings (e.g., onboarding_title_welcome, onboarding_desc_connect_gateway, button_next, show_password), which makes Spanish the fallback for all locales; move these Spanish entries into a new values-es/strings.xml and populate values/strings.xml with English fallback strings (or, if Spanish-first is intentional, add a clear README/manifest note stating that values/ is Spanish-first and keep strings where they are). Ensure keys remain identical (onboarding_title_welcome, onboarding_desc_welcome, onboarding_title_connect_gateway, onboarding_desc_connect_gateway, onboarding_title_talk_agent, onboarding_desc_talk_agent, button_skip, button_next, button_start, show_password, hide_password) so resource lookups continue to work.
♻️ Duplicate comments (2)
clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.kt (1)
89-89: Hardcoded"Hide"/"Show"contentDescription strings still not localized.The string resources
show_password/hide_passwordwere added to bothvalues/andvalues-en/in this same PR, yet the call site still uses literals. The commit message cites "internal visibility limits" for revertingstringResource, butstringResource()fromorg.jetbrains.compose.resourcesis not gated by Kotlin visibility —internalcomposables can call it freely. Please verify whether that blocker still applies.Compose Multiplatform stringResource internal composable visibility restrictions🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.kt` at line 89, Replace the hardcoded contentDescription literal at the contentDescription = if (isVisible) "Hide" else "Show" site with localized resources: call stringResource(R.string.hide_password) when isVisible is true and stringResource(R.string.show_password) otherwise (use the existing show_password / hide_password resources); ensure you import and use org.jetbrains.compose.resources.stringResource (or the project’s stringResource alias) in ChatComponents.kt and remove the incorrect "internal visibility limits" workaround—verify stringResource is callable from the current scope and update the conditional to reference those resource IDs instead of literals.clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md (1)
105-105: Aún queda terminología mixta (loop) en una oración en español.Esto ya fue señalado antes y sigue visible en el texto; conviene cambiarlo por “bucle” para mantener consistencia editorial.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md` at line 105, Replace the mixed-language term "loop" with the Spanish equivalent "bucle" in the sentence that currently reads "patrón de loop de ejecución" so the phrase becomes "patrón de bucle de ejecución"; update any other occurrences in the same paragraph that use "loop" to "bucle" to maintain editorial consistency (look for the sentence starting "El agente utiliza un patrón de loop de ejecución...").
🧹 Nitpick comments (1)
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md (1)
111-117: Evita versionar modelos concretos dentro del documento de arquitectura.Listar modelos/versiones específicos aquí vuelve el documento frágil; mejor dejar categorías de proveedores y mover ejemplos/versiones a una página de compatibilidad o matriz viva.
As per coding guidelines, “
**/*: Focus on project-wide best practices.”🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md` around lines 111 - 117, Remove specific model/version names from the architecture document and replace with generic provider categories (e.g., "OpenAI-compatible models", "Anthropic-compatible models", "Google Gemini", "local runtimes like Ollama", "aggregators like OpenRouter"); keep the mention of the routing implementation (`providers/router.rs`) and channel trait (`channels/` and trait Channel) but move concrete model/version examples to the compatibility/matrix page, or reference that page for exact supported model versions. Ensure the architecture text stays high-level and resilient by not enumerating model versions here and by adding a single line pointer to the compatibility matrix for up-to-date model lists.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md`:
- Line 135: Edit the sentence describing Landlock in the architecture doc to
remove the implication that filesystem and network restrictions are equivalent:
explicitly state that network restrictions are only available starting with
Landlock ABI v4 (Linux 6.7+) and that Landlock's network API is TCP port–centric
(can control TCP bind/connect by port) and cannot restrict UDP, raw sockets,
DNS-by-name, or IP ranges; update the Landlock mention so it either separates
filesystem capability (supported on older kernels 5.13–6.2) from network
capability (requires 6.7+) or add a concise note listing these kernel and
protocol limitations.
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md`:
- Line 14: The Spanish headings use title case; update them to sentence-style
capitalization (only capitalize the first word and proper nouns). For example,
change the heading "## 1) Objetivos de Gobernanza" to "## 1) Objetivos de
gobernanza" and apply the same change to the other headings called out (lines
with headings at 21, 32, 103, 119, 138, 158, 172) so common nouns are lowercased
while keeping proper nouns capitalized.
- Line 125: In the markdown line containing "3. Re-introducir fix solo con tests
de regresión." remove the hyphen so the single-word Spanish verb is correct:
change "Re-introducir" to "Reintroducir" and keep the rest of the sentence
unchanged.
- Line 135: The sentence "Plan de rollback es explícito." is missing the
definite article; update the text in the document so the phrase reads "El plan
de rollback es explícito." (locate the exact string "Plan de rollback es
explícito." in the file and replace it with "El plan de rollback es
explícito.").
- Line 87: The Spanish sentence is missing the definite article; update the text
"**No** requerimos que contribuidores cuantifiquen propiedad de líneas
AI-vs-humano." to include the article before "contribuidores" (i.e., "No
requerimos que los contribuidores cuantifiquen propiedad de líneas
AI-vs-humano.") so the phrase reads grammatically correct; locate the exact
string in pr-workflow.md and replace it accordingly.
- Line 44: Edit the sentence "PRs no-docs deben pasar lint, tests, y smoke check
de release build." to remove the serial comma before "y" so it reads "PRs
no-docs deben pasar lint, tests y smoke check de release build."; update the
line in the document where that exact string appears.
- Line 179: Capitalize the first letter of list item 4 by changing the text "4.
siguiente acción sugerida." to "4. Siguiente acción sugerida." so it matches the
capitalization style of items 1–3 and ensures consistency in the list.
---
Outside diff comments:
In `@clients/composeApp/src/commonMain/composeResources/values/strings.xml`:
- Around line 1-19: The values/ directory currently contains Spanish strings
(e.g., onboarding_title_welcome, onboarding_desc_connect_gateway, button_next,
show_password), which makes Spanish the fallback for all locales; move these
Spanish entries into a new values-es/strings.xml and populate values/strings.xml
with English fallback strings (or, if Spanish-first is intentional, add a clear
README/manifest note stating that values/ is Spanish-first and keep strings
where they are). Ensure keys remain identical (onboarding_title_welcome,
onboarding_desc_welcome, onboarding_title_connect_gateway,
onboarding_desc_connect_gateway, onboarding_title_talk_agent,
onboarding_desc_talk_agent, button_skip, button_next, button_start,
show_password, hide_password) so resource lookups continue to work.
---
Duplicate comments:
In
`@clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.kt`:
- Line 89: Replace the hardcoded contentDescription literal at the
contentDescription = if (isVisible) "Hide" else "Show" site with localized
resources: call stringResource(R.string.hide_password) when isVisible is true
and stringResource(R.string.show_password) otherwise (use the existing
show_password / hide_password resources); ensure you import and use
org.jetbrains.compose.resources.stringResource (or the project’s stringResource
alias) in ChatComponents.kt and remove the incorrect "internal visibility
limits" workaround—verify stringResource is callable from the current scope and
update the conditional to reference those resource IDs instead of literals.
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md`:
- Line 105: Replace the mixed-language term "loop" with the Spanish equivalent
"bucle" in the sentence that currently reads "patrón de loop de ejecución" so
the phrase becomes "patrón de bucle de ejecución"; update any other occurrences
in the same paragraph that use "loop" to "bucle" to maintain editorial
consistency (look for the sentence starting "El agente utiliza un patrón de loop
de ejecución...").
---
Nitpick comments:
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md`:
- Around line 111-117: Remove specific model/version names from the architecture
document and replace with generic provider categories (e.g., "OpenAI-compatible
models", "Anthropic-compatible models", "Google Gemini", "local runtimes like
Ollama", "aggregators like OpenRouter"); keep the mention of the routing
implementation (`providers/router.rs`) and channel trait (`channels/` and trait
Channel) but move concrete model/version examples to the compatibility/matrix
page, or reference that page for exact supported model versions. Ensure the
architecture text stays high-level and resilient by not enumerating model
versions here and by adding a single line pointer to the compatibility matrix
for up-to-date model lists.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
assets/corvus-log.pngis excluded by!**/*.pngassets/corvus-log.svgis excluded by!**/*.svg
📒 Files selected for processing (11)
README.mdclients/agent-runtime/CONTRIBUTING.mdclients/agent-runtime/README.mdclients/agent-runtime/src/identity.rsclients/composeApp/src/commonMain/composeResources/values-en/strings.xmlclients/composeApp/src/commonMain/composeResources/values/strings.xmlclients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatComponents.ktclients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.ktclients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ConfigPanel.ktclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.mdclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
✅ Files skipped from review due to trivial changes (1)
- clients/agent-runtime/src/identity.rs
🚧 Files skipped from review as they are similar to previous changes (4)
- clients/agent-runtime/CONTRIBUTING.md
- clients/agent-runtime/README.md
- clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ConfigPanel.kt
- clients/composeApp/src/commonMain/kotlin/com/profiletailors/corvus/ui/chat/ChatWorkspace.kt
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Outdated
Show resolved
Hide resolved
ES documentation: - architecture.md: loop→bucle, detailed Landlock limitations (kernel 5.13-6.2 for fs, 6.7+ for network, TCP-only), remove model versions, add compatibility matrix reference - pr-workflow.md: sentence-case headings, Reintroducir (no hyphen), el plan de rollback, los contribuidores, remove serial comma, Siguiente capital String resources: - values/strings.xml: English fallback strings - values-es/strings.xml: Spanish strings (moved from values/) - Remove old values-en/ directory Note: ChatComponents.kt stringResource reverted - generated resources have internal visibility limiting access from other modules.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md (3)
101-101: Divide la regla depr-hygieneen criterios explícitos.La línea mezcla frecuencia, condición de edad y dos estados de bloqueo en una sola oración; separar criterios mejora ejecución consistente del triaje.
✏️ Propuesta de ajuste
-- Automatización `pr-hygiene` revisa PRs abiertos cada 12 horas y publica nudge cuando un PR no tiene nuevos commits por 48+ horas y está detrás de `main` o tiene `CI Required Gate` fallando/missing en el head commit. +- Automatización `pr-hygiene` revisa PRs abiertos cada 12 horas. +- Publica un nudge cuando un PR no tiene nuevos commits por 48+ horas y además: + - está detrás de `main`, o + - tiene `CI Required Gate` en estado failing/missing en el head commit.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md` at line 101, Split the single sentence describing the `pr-hygiene` rule into explicit criteria: (1) schedule/frequency (e.g., "runs every 12 hours"), (2) staleness threshold (e.g., "no new commits for 48+ hours"), and (3) blocking states expressed separately (e.g., "PR is behind `main`" OR "head commit has `CI Required Gate` failing or missing"); update the documentation line so each criterion is its own clause or list item and keep the rule name `pr-hygiene` intact for reference.
36-36: Haz explícitos los campos mínimos del template en vez de “completo”.“Completo” es subjetivo; listar campos obligatorios reduce variabilidad entre autores y revisores.
✏️ Propuesta de ajuste
-- Contributor abre PR con `.github/pull_request_template.md` completo. +- Contributor abre PR con `.github/pull_request_template.md` completo, incluyendo: problema, cambio, no-objetivos, riesgos y plan de rollback.Based on learnings: "Follow
.github/pull_request_template.mdand keep PR descriptions concrete with problem, change, non-goals, risk, and rollback information".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md` at line 36, Reemplaza la frase "Contributor abre PR con `.github/pull_request_template.md` completo." por una versión que haga explícitos los campos obligatorios del template; menciona concretamente que la PR debe incluir: "problema", "cambio", "no-objetivos", "riesgos" y "plan de rollback" (o campos equivalentes), y sugiere seguir `.github/pull_request_template.md` para mantener la descripción concreta; actualiza la línea que contiene esa exacta cadena para reflejar estos campos mínimos obligatorios.
72-75: Unifica terminología ES/EN para evitar ambigüedad operativa.Hay mezcla de términos (
AI/Agent,agent) en una guía en español. Conviene estandarizar aIA/agenteen todo el documento.✏️ Propuesta de ajuste
-## 5) Política de Contribución AI/Agent +## 5) Política de contribución IA/agente -PRs asistidos por AI son bienvenidos, y la revisión también puede ser asistida por agent. +Los PRs asistidos por IA son bienvenidos, y la revisión también puede ser asistida por un agente. -## 10) Modelo operativo de revisión por agent +## 10) Modelo operativo de revisión por agente -## 12) Contrato de handoff de agent +## 12) Contrato de handoff de agente -Cuando un agent hace handoff a otro (o a un maintainer), incluir: +Cuando un agente hace handoff a otro (o a un maintainer), incluir:Also applies to: 138-138, 172-174
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md` around lines 72 - 75, Unifica la terminología en este documento reemplazando todas las apariciones mixtas de "AI/Agent", "AI Agent", "AI", y "agent" (cuando se refieren al software agente) por "IA/agente" con formato consistente (IA en mayúsculas, agente en minúscula); en particular cambia el encabezado "Política de Contribución AI/Agent" y cualquier ocurrencia de la palabra "agent" en el cuerpo a "IA/agente", revisa también las otras instancias reportadas para los párrafos alrededor de las referencias y asegúrate de mantener la concordancia gramatical en frases que usen artículo o plural.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@clients/composeApp/src/commonMain/composeResources/values/strings.xml`:
- Around line 18-19: Update the password-visibility string resources so screen
readers get descriptive labels: change the string resource values for
show_password and hide_password from "Show"/"Hide" to "Show password"/"Hide
password", and apply the equivalent change in the Spanish locale strings.xml
(replace the single-word translations with the full "Mostrar
contraseña"/"Ocultar contraseña" or the project's chosen Spanish phrasing) so
both default and es locale string resources use the descriptive noun.
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md`:
- Line 111: Remove the Spanish serial (Oxford) commas before the final "y" in
lists across this document; search for comma-plus-"y" patterns in sentences like
the one referencing providers and routing (e.g., the sentence mentioning
"OpenAI, Anthropic, Google Gemini, runtimes locales como Ollama, agregadores
como OpenRouter, y GitHub Copilot") and delete the comma immediately before "y"
so lists read "...OpenRouter y GitHub Copilot"; apply the same fix for the other
occurrences noted (around the referenced lines) and ensure no other list in this
file leaves a comma directly before "y"; keep punctuation and spacing consistent
after removal and do not alter other wording or code references such as
providers/router.rs.
- Line 93: Edit the sentence beginning "Los módulos de seguridad (`security/`)
implementan múltiples capas de protección..." to add a comma after "protección"
(i.e., "protección, incluyendo...") and remove the comma before "y gestión de
secretos cifrada" so the clause reads without the serial/Oxford comma; ensure
spacing and punctuation remain correct.
- Line 3: Update all section headings in this markdown to Spanish sentence-case:
only capitalize the first word and any proper nouns. For example, change "Visión
General" to "Visión general" and apply the same rule to every multi-word heading
in this file (the other headings flagged in the review). Edit the heading text
directly in the document so each section heading follows Spanish sentence-case
throughout.
---
Nitpick comments:
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md`:
- Line 101: Split the single sentence describing the `pr-hygiene` rule into
explicit criteria: (1) schedule/frequency (e.g., "runs every 12 hours"), (2)
staleness threshold (e.g., "no new commits for 48+ hours"), and (3) blocking
states expressed separately (e.g., "PR is behind `main`" OR "head commit has `CI
Required Gate` failing or missing"); update the documentation line so each
criterion is its own clause or list item and keep the rule name `pr-hygiene`
intact for reference.
- Line 36: Reemplaza la frase "Contributor abre PR con
`.github/pull_request_template.md` completo." por una versión que haga
explícitos los campos obligatorios del template; menciona concretamente que la
PR debe incluir: "problema", "cambio", "no-objetivos", "riesgos" y "plan de
rollback" (o campos equivalentes), y sugiere seguir
`.github/pull_request_template.md` para mantener la descripción concreta;
actualiza la línea que contiene esa exacta cadena para reflejar estos campos
mínimos obligatorios.
- Around line 72-75: Unifica la terminología en este documento reemplazando
todas las apariciones mixtas de "AI/Agent", "AI Agent", "AI", y "agent" (cuando
se refieren al software agente) por "IA/agente" con formato consistente (IA en
mayúsculas, agente en minúscula); en particular cambia el encabezado "Política
de Contribución AI/Agent" y cualquier ocurrencia de la palabra "agent" en el
cuerpo a "IA/agente", revisa también las otras instancias reportadas para los
párrafos alrededor de las referencias y asegúrate de mantener la concordancia
gramatical en frases que usen artículo o plural.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
clients/composeApp/src/commonMain/composeResources/values-es/strings.xmlclients/composeApp/src/commonMain/composeResources/values/strings.xmlclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.mdclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
✅ Files skipped from review due to trivial changes (1)
- clients/composeApp/src/commonMain/composeResources/values-es/strings.xml
clients/composeApp/src/commonMain/composeResources/values/strings.xml
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md
Outdated
Show resolved
Hide resolved
# Conflicts: # README.md # clients/agent-runtime/README.md # clients/agent-runtime/src/identity.rs
# Conflicts: # clients/agent-runtime/Cargo.lock
String resources: - values/strings.xml: Show password → Show password (descriptive for screen readers) - values-es/strings.xml: Mostrar → Mostrar contraseña, Ocultar → Ocultar contraseña ES documentation (architecture.md): - Sentence-case headings (Visión general, Principios de diseño, etc.) - Remove serial comma before "y" in provider list - Add comma after "protección" in security section ES documentation (pr-workflow.md): - Sentence-case headings (Política de tamaño de PR, SLA de revisión, etc.) - pr-hygiene: split into explicit criteria - PR template: list mandatory fields (problema, cambio, no-objetivos, riesgos, rollback)
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md (1)
138-138:⚠️ Potential issue | 🟡 Minor"agent" → "agente" in Spanish prose (spelling error).
The prior heading-capitalisation fix proposed
agentein its diff but the English term was not updated. LanguageTool flags both occurrences as spelling errors.✍️ Propuesta de ajuste
-## 10) Modelo operativo de revisión por agent +## 10) Modelo operativo de revisión por agente-Cuando un agent hace handoff a otro (o a un maintainer), incluir: +Cuando un agente hace handoff a otro (o a un maintainer), incluir:Also update the section title reference in line 172:
-## 12) Contrato de handoff de agent +## 12) Contrato de handoff de agenteAlso applies to: 174-174
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md` at line 138, Replace the English word "agent" with the Spanish "agente" in the heading text "## 10) Modelo operativo de revisión por agent" and in the other in-page references that still use "agent" (the section title mention and any occurrences around the section reference lines), ensuring the heading and all localized prose use "agente" consistently; update the two other instances flagged (the section title reference and the additional mention) so the Spanish spelling is uniform.clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md (1)
121-121:⚠️ Potential issue | 🟡 MinorSerial commas before "y" still present — remove them.
Spanish does not use the Oxford/serial comma. Despite being marked as addressed in a previous commit, all six instances remain in the current file.
✍️ Propuesta de ajuste
-...chunking inteligente para documentos grandes, y caching de respuestas para evitar regenerar contenido idéntico. +...chunking inteligente para documentos grandes y caching de respuestas para evitar regenerar contenido idéntico.-...integración con Composio para herramientas externas, y herramientas de memoria para persistir y recuperar información. +...integración con Composio para herramientas externas y herramientas de memoria para persistir y recuperar información.-...microcontroladores STM32 Nucleo, dispositivos serie genéricos, y capacidades de flash de firmware. +...microcontroladores STM32 Nucleo, dispositivos serie genéricos y capacidades de flash de firmware.-...consulta la memoria para contexto relevante, y determina qué acciones tomar. +...consulta la memoria para contexto relevante y determina qué acciones tomar.-...cómo parsear la respuesta, y cómo manejar errores específicos del proveedor. +...cómo parsear la respuesta y cómo manejar errores específicos del proveedor.-...qué red puede alcanzar, y qué periféricos puede controlar. +...qué red puede alcanzar y qué periféricos puede controlar.Also applies to: 125-125, 129-129, 143-143, 151-151, 165-165
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md` at line 121, Several sentences in the "El sistema de memoria (`memory/`)" paragraph and nearby lines still contain Spanish serial (Oxford) commas before "y"; locate the occurrences that include commas immediately preceding " y " (e.g., the sentence starting "A diferencia de agentes simples..." and the other five instances around the paragraph), and remove the comma(s) before "y" so the conjunction is not preceded by a comma; update the lines containing those sentences (references: the sentence containing "A diferencia de agentes simples...", and the similar sentences at the other reported spots) ensuring spacing and punctuation remain correct after removal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md`:
- Line 50: En la línea que contiene la frase "PRs grandes (`size: L`/`size: XL`)
deben dividirse salvo justificación fuerte." añade una coma antes de "salvo"
para separar la cláusula adverbial: cambia a "PRs grandes (`size: L`/`size: XL`)
deben dividirse, salvo justificación fuerte." Mantén el resto del texto igual.
---
Duplicate comments:
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.md`:
- Line 121: Several sentences in the "El sistema de memoria (`memory/`)"
paragraph and nearby lines still contain Spanish serial (Oxford) commas before
"y"; locate the occurrences that include commas immediately preceding " y "
(e.g., the sentence starting "A diferencia de agentes simples..." and the other
five instances around the paragraph), and remove the comma(s) before "y" so the
conjunction is not preceded by a comma; update the lines containing those
sentences (references: the sentence containing "A diferencia de agentes
simples...", and the similar sentences at the other reported spots) ensuring
spacing and punctuation remain correct after removal.
In
`@clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md`:
- Line 138: Replace the English word "agent" with the Spanish "agente" in the
heading text "## 10) Modelo operativo de revisión por agent" and in the other
in-page references that still use "agent" (the section title mention and any
occurrences around the section reference lines), ensuring the heading and all
localized prose use "agente" consistently; update the two other instances
flagged (the section title reference and the additional mention) so the Spanish
spelling is uniform.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
clients/composeApp/src/commonMain/composeResources/values-es/strings.xmlclients/composeApp/src/commonMain/composeResources/values/strings.xmlclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/architecture.mdclients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
✅ Files skipped from review due to trivial changes (1)
- clients/composeApp/src/commonMain/composeResources/values-es/strings.xml
clients/web/apps/docs/src/content/docs/es/clients/agent-runtime/pr-workflow.md
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs now live in: docs/src/content/docs/{lang}/clients/agent-runtime/
Summary by CodeRabbit
Documentation
Localization
Bug Fixes
Refactor