Open
Conversation
The phrase "Please contact me" sounds like one should send an email (or similar) to someone, whereas what is meant is that the server has started at the given address. This change should improve the clarity of the message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phrase "Please contact me" sounds like one should send an email (or
similar) to someone, whereas what is meant is that the server has
started at the given address. This change should improve the clarity of
the message.
By the way: why does the server start message need to be printed to STDERR? It seems like the wrong place, since it's not an error that's occuring; the message seems to be purely informative. Would you like me to perhaps change the
printto output to simplySTDOUT?