Prefer Rails.root to RAILS_ROOT#3
Open
ardbytes wants to merge 6 commits intodan-manges:masterfrom
ardbytes:master
Open
Prefer Rails.root to RAILS_ROOT#3ardbytes wants to merge 6 commits intodan-manges:masterfrom ardbytes:master
ardbytes wants to merge 6 commits intodan-manges:masterfrom
ardbytes:master
Conversation
Owner
|
Thanks for the pull request. I'm working on full Rails 3 support, down to 1 failing spec. |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dan,
I have made a small change to unit_record making it compatible with Rails 3.0. Would you accept the pull request and release a new version of the gem. Let me know if I am missing anything.
Cheers,
Arvind