openbox-xdg-autostart.c : drop-in replacement for python script#13
Open
techzilla wants to merge 2 commits intodanakj:masterfrom
techzilla:master
Open
openbox-xdg-autostart.c : drop-in replacement for python script#13techzilla wants to merge 2 commits intodanakj:masterfrom techzilla:master
techzilla wants to merge 2 commits intodanakj:masterfrom
techzilla:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the openbox-xdg-autostart Python script is an ideal candidate for a C drop-in replacement. After checking the obsession code I noticed it was from an older lxsession xdg-autostart.c. So I made a new one using functions copied verbatim from 0.4.6.1 lxsession xdg-autostart.c. All it required was a couple declarations for compile, and create a new main() function that accepted the desktop name as an argument. I was able to seamlessly replace the Python script executed from openbox-autostart shell script, and my .desktop's executed as expected. The only thing left to do after these two commits, would be modifying the openbox-autostart script, but I thought it best best to get some feedback on this first.