Added the options "once" and "strict" to the actions GrowTo* and MoveTo*#8
Open
deters wants to merge 19 commits intodanakj:workfrom
Open
Added the options "once" and "strict" to the actions GrowTo* and MoveTo*#8deters wants to merge 19 commits intodanakj:workfrom
deters wants to merge 19 commits intodanakj:workfrom
Conversation
Currently the code rolls its own binary search, but now that we have a well-tested binary search implementation in obt/ we can make use of that.
This extend the client_find_resize_directional() method to support two growing modes, and return a bool for whether it was able to grow/shrink. The client_find_resize_directional() method now takes an enum instead of a bool, with two growing modes. The old mode which always tries to grow, the a new mode that will only grow if the client's edge is not already at a grow stopping point (ie against the edge of another window).
This change points out how useless the return value from client_find_resize_directional() was, so it also removes that. When all edges are blocked, the FillToEdge action will try to grow all four edges agin without blocking any of them on their current edge. This more closely matches the behaviour of the GrowToEdge action.
Conflicts: openbox/actions/growtoedge.c
Conflicts: openbox/actions/growtoedge.c
… into growtofill_option
… into growtofill_option
… into growtofill_option
… into growtofill_option
… into growtofill_option
… into growtofill_option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed... github updates automatically my pull request to the latest revision...
I'm proposing this 2 new options:
"once": will restrict GrowTo_/MoveTo_ to the nearest blocking edges.
"strict": forces GrowTo* actions to do strictly what they name says: grow. So, this option will prevent GrowTo from shrinking.
The name "strict" is just a suggestion, I tryed to think in a generic name who could be applied to any other methods who have "controversal" behaviours. The "strict" was implemented only on GrowTo* actions.
More info & Usage:
https://bugzilla.icculus.org/show_bug.cgi?id=3356#c38