Change DJANGO_DEFAULT_FROM_EMAIL value#263
Conversation
kabilar
changed the title
DJANGO_DEFAULT_FROM_EMAILDJANGO_DEFAULT_FROM_EMAIL value
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
I don't think this will solve the problem of the weird Heroku email addresses being shown to users, but putting that aside, I think this is the correct email address to use (rather than the api.dandiarchive.org domain).
@jjnesbitt, if you don't object, let's go ahead and merge this.
| DJANGO_CORS_ALLOWED_ORIGINS = join(",", ["https://sandbox.dandiarchive.org", "https://neurosift.app"]) | ||
| DJANGO_CORS_ALLOWED_ORIGIN_REGEXES = join(",", ["^https:\\/\\/[0-9a-z\\-]+--sandbox-dandiarchive-org\\.netlify\\.app$"]) | ||
| DJANGO_DEFAULT_FROM_EMAIL = "admin@api.sandbox.dandiarchive.org" | ||
| DJANGO_DEFAULT_FROM_EMAIL = "info@dandiarchive.org" |
There was a problem hiding this comment.
Should this not be info@api.sandbox.dandiarchive.org?
There was a problem hiding this comment.
Or rather, info@sandbox.dandiarchive.org
There was a problem hiding this comment.
It should probably be info@dandiarchive.org, since that email will reach the admin team (via ImprovMX).
I can probably set up mailbox forwarding for sandbox.dandiarchive.org, but that would be a new thing for the project.
There was a problem hiding this comment.
In that case, I'd say we should probably update our email templates, to distinguish prod from sandbox. At the moment, the only way to differentiate them is the email address sent from.
|
I agree with @waxlamp that I don't believe this will close the linked issue. I've reworded the description so that it won't automatically close. |
jjnesbitt
left a comment
jjnesbitt
left a comment
There was a problem hiding this comment.
I agree this won't resolve the linked issue, but I don't object to it.
3 participants
I am not entirely sure if this is the complete fix, but I am hoping this addresses dandi/dandi-archive#2018.